Fix review findings

Author: sunildevda

process/folder_templates/features/feature_name/index.rst

@@ -185,3 +185,4 @@ Footnotes
    safety_analysis/fmea.rst
    safety_analysis/dfa.rst
    safety_planning/index.rst
+   security_planning/index.rst

process/folder_templates/features/feature_name/security_planning/index.rst

@@ -0,0 +1,145 @@
+..
+   # *******************************************************************************
+   # Copyright (c) 2025 Contributors to the Eclipse Foundation
+   #
+   # See the NOTICE file(s) distributed with this work for additional
+   # information regarding copyright ownership.
+   #
+   # This program and the accompanying materials are made available under the
+   # terms of the Apache License Version 2.0 which is available at
+   # https://www.apache.org/licenses/LICENSE-2.0
+   #
+   # SPDX-License-Identifier: Apache-2.0
+   # *******************************************************************************
+
+.. _feature_security_wp_template:
+
+Feature Security Work Products List
+###################################
+
+.. document:: [Your Feature Name] Security WPs
+   :id: doc__feature_name_security_wp
+   :status: draft
+   :safety: ASIL_B
+   :security: YES
+   :realizes: wp__platform_security_plan
+   :tags: template
+
+.. attention::
+    The above directive must be updated according to your Feature.
+
+    - Modify ``Your Feature Name`` to be your Feature Name
+    - Modify ``id`` to be your Module Name in upper snake case preceded by ``doc__`` and succeeded by ``_security_wp``
+    - Adjust ``status`` to be ``valid``
+    - Adjust ``safety`` and ``tags`` according to your needs
+
+Tailoring
+=========
+
+Additional to the tailoring in the SW platform project as defined in the project's :need:`wp__platform_security_plan` we define here the additional tailoring on feature level.
+
+- Excluded for this feature are additionally the following work products (and their related requirements):
+
+  - <work product/requirement> - <Argumentation why it is not needed or replaced by another work product or activity.>
+
+
+Security Work products List
+===========================
+
+.. list-table:: Feature <feature_name> Work products
+    :header-rows: 1
+
+    * - Work product Id
+      - Link to process
+      - Process status
+      - Link to WP
+
+    * - :need:`wp__feat_request`
+      - :need:`gd_temp__change_feature_request`
+      - :ndf:`copy('status', need_id='gd_temp__change_feature_request')`
+      - :need:`doc__feature_name`
+
+    * - :need:`wp__requirements_feat`
+      - :need:`gd_temp__req_feat_req`
+      - :ndf:`copy('status', need_id='gd_temp__req_feat_req')`
+      - :need:`doc__feature_name_requirements`
+
+    * - :need:`wp__requirements_feat_aou`
+      - :need:`gd_temp__req_aou_req`
+      - :ndf:`copy('status', need_id='gd_temp__req_aou_req')`
+      - :need:`doc__feature_name_requirements`
+
+    * - :need:`wp__feature_arch`
+      - :need:`gd_temp__arch_feature`
+      - :ndf:`copy('status', need_id='gd_temp__arch_feature')`
+      - :need:`doc__feature_name_architecture`
+
+    * - :need:`wp__requirements_inspect`
+      - :need:`gd_chklst__req_inspection`
+      - :ndf:`copy('status', need_id='gd_chklst__req_inspection')`
+      - :need:`doc__feature_name_req_inspection`
+
+    * - :need:`wp__sw_arch_verification`
+      - :need:`gd_chklst__arch_inspection_checklist`
+      - :ndf:`copy('status', need_id='gd_chklst__arch_inspection_checklist')`
+      - :need:`doc__feature_name_arc_inspection`
+
+    * - :need:`wp__verification_feat_int_test`
+      - :need:`gd_guidl__verification_guide`
+      - :ndf:`copy('status', need_id='gd_guidl__verification_guide')`
+      - <Link to WP>
+
+.. attention::
+    The above table must be updated according to your feature security planning.
+
+    - Fill the work producs links
+
+Feature Security Package
+========================
+
+To create the security package (according to :need:`gd_guidl__security_package`) the following
+documents and work products status have to go to "valid" (after the relevant verification were performed).
+
+Feature Documents Status
+------------------------
+
+For all the work product documents the status can be seen by following the "Link to WP".
+A summary of the status is also documented in the project's documentation management plan.
+
+See <add here the section reference to the documentation management plan>
+
+Feature Requirements Status
+---------------------------
+
+.. needtable::
+   :filter: "feature_name" in docname and "requirements" in docname and docname is not None
+   :style: table
+   :types: feat_req
+   :tags: feature_name
+   :columns: id;status
+   :colwidths: 25,25
+   :sort: title
+
+Feature AoU Status
+------------------
+
+.. needtable::
+   :filter: "feature_name" in docname and "requirements" in docname and docname is not None
+   :style: table
+   :types: aou_req
+   :tags: feature_name
+   :columns: id;status
+   :colwidths: 25,25
+   :sort: title
+
+Feature Architecture Status
+---------------------------
+
+.. needtable::
+   :filter: "feature_name" in docname and "architecture" in docname and docname is not None
+   :style: table
+   :types: feat_arc_sta; feat_arc_dyn
+   :tags: feature_name
+   :columns: id;status
+   :colwidths: 25,25
+   :sort: title

process/process_areas/process_management/process_management_concept.rst

@@ -62,9 +62,13 @@ Stakeholders for the Process Management
 
    * Supports all activities
 
-#. :need:`External Auditor <rl__external_auditor>`
+#. :need:`Safety External Auditor <rl__safety_external_auditor>`
 
-   * Supports all activities, especially during iterative audits
+   * Supports all safety activities, especially during iterative audits
+
+#. :need:`Security External Auditor <rl__security_external_auditor>`
+
+   * Supports all security activities, especially during iterative audits
 
 Standard Requirements
 =====================
@@ -121,7 +125,7 @@ using standard pull requests.
 
 Process Description are approved by the :need:`rl__process_community`.
 
-Regular audits supported by :need:`rl__external_auditor` ensure compliance with
+Regular audits supported by :need:`rl__safety_external_auditor` and :need:`rl__security_external_auditor` ensure compliance with
 existing standards.
 
 .. _pm_mc_process:

process/process_areas/process_management/process_management_roles.rst

@@ -21,7 +21,8 @@ Contributing Roles:
 
    * :need:`Contributor <rl__contributor>`
    * :need:`Process Community <rl__process_community>`
-   * :need:`External Auditor <rl__external_auditor>`
+   * :need:`Safety External Auditor <rl__safety_external_auditor>`
+   * :need:`Security External Auditor <rl__security_external_auditor>`
    * :need:`Project Lead <rl__project_lead>`
 
 A detailed overview of the responsibility for the steps of the requirement process is listed here:

process/process_areas/process_management/process_management_workflow.rst

@@ -24,7 +24,7 @@ For a detailed explanation of workflows and their role within the process model,
    :status: valid
    :responsible: rl__contributor
    :approved_by: rl__process_community
-   :supported_by: rl__external_auditor, rl__project_lead
+   :supported_by: rl__safety_external_auditor, rl__security_external_auditor, rl__project_lead
    :input: wp__policies, wp__issue_track_system
    :output: wp__process_strategy, wp__policies
    :contains: gd_guidl__process_management, gd_temp__process_workflow
@@ -38,7 +38,7 @@ For a detailed explanation of workflows and their role within the process model,
    :status: valid
    :responsible: rl__contributor
    :approved_by: rl__process_community
-   :supported_by: rl__external_auditor, rl__project_lead
+   :supported_by: rl__safety_external_auditor, rl__security_external_auditor, rl__project_lead
    :input: wp__process_strategy, wp__issue_track_system
    :output: wp__process_description, wp__tailoring_work_products
    :contains: gd_guidl__process_management, gd_temp__process_workflow
@@ -51,7 +51,7 @@ For a detailed explanation of workflows and their role within the process model,
    :status: valid
    :responsible: rl__contributor
    :approved_by: rl__process_community
-   :supported_by: rl__external_auditor, rl__project_lead
+   :supported_by: rl__safety_external_auditor, rl__security_external_auditor, rl__project_lead
    :input: wp__process_description
    :output: wp__process_impr_report, wp__issue_track_system
    :contains: gd_guidl__process_management, gd_temp__process_workflow

process/process_areas/safety_management/safety_management_concept.rst

@@ -76,7 +76,7 @@ Stakeholders
 
    * Supports activities
 
-#. :need:`External Auditor <rl__external_auditor>`
+#. :need:`Safety External Auditor <rl__safety_external_auditor>`
 
    * Perform Safety Audit as independent safety audits
    * Verifies compliance with defined safety processes and standards.

process/process_areas/safety_management/safety_management_roles.rst

@@ -69,8 +69,8 @@ Roles
    * Refusing the approval of work products as defined in the workflows
    * Refusing the approval of his team's role nomination (i.e. requesting that the role will be withdrawn)
 
-.. role:: External Auditor
-   :id: rl__external_auditor
+.. role:: Safety External Auditor
+   :id: rl__safety_external_auditor 
    :status: valid
 
    Required skills, Knowledge of standards, Experience

process/process_areas/safety_management/safety_management_workflow.rst

@@ -62,7 +62,7 @@ Safety Management Workflows
 .. workflow:: Perform Safety Audit
    :id: wf__p_fs_audit
    :status: valid
-   :responsible: rl__external_auditor
+   :responsible: rl__safety_external_auditor
    :approved_by: rl__safety_manager
    :input: wp__module_safety_plan, wp__platform_safety_plan, wp__module_safety_package, wp__platform_safety_package
    :output: wp__audit_report

process/process_areas/security_management/guidance/index.rst

@@ -21,7 +21,6 @@ Guidance
    security_management_guideline
    security_plan_templates
    security_manual_templates
-   security_management_feature_security_wp_template
    checklist_security_package
    checklist_security_plan
    security_management_process_reqs