Right now, we have a hoisted node_modules folder in the root directory when building, stemming from dependencies in the root package.json and the following workspace folders:
vscode-builtin-extensions",
"browser-app",
"electron-app"
However, this can lead to problems when building vscode: just remove yarn.lock and try to do yarn in the root folder: there will be compile problems when the "build:extensions" script invokes yarn inside the vscode folder.
The problem is that "prepare" is invoked after after the dependencies are installed into the root-level node_modules folder. Since the resolved version of some packages is not compatible with the vscode version we're checked out, this fails. The problem arises because the typescript compiler picks up the version of @types/htmlparser2, for example, from /node_modules, not /vscode/node_modules.
I propose that we separate the the vscode folder and everything else by moving everything that is at the root level now (except the vscode folder) to a subfolder named 'packaging'. With no hoisting to the root folder, we would have completely separate node_modules folders, which would be correct on a more conceptual level as well: the packaging tools have an independent module universe from vscode.
Right now, we have a hoisted node_modules folder in the root directory when building, stemming from dependencies in the root package.json and the following workspace folders:
However, this can lead to problems when building vscode: just remove yarn.lock and try to do
yarnin the root folder: there will be compile problems when the "build:extensions" script invokes yarn inside the vscode folder.The problem is that "prepare" is invoked after after the dependencies are installed into the root-level node_modules folder. Since the resolved version of some packages is not compatible with the vscode version we're checked out, this fails. The problem arises because the typescript compiler picks up the version of @types/htmlparser2, for example, from /node_modules, not /vscode/node_modules.
I propose that we separate the the vscode folder and everything else by moving everything that is at the root level now (except the vscode folder) to a subfolder named 'packaging'. With no hoisting to the root folder, we would have completely separate node_modules folders, which would be correct on a more conceptual level as well: the packaging tools have an independent module universe from vscode.