-
Notifications
You must be signed in to change notification settings - Fork 25
chore: signal reviewer of migrations happening #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lusergit
wants to merge
1
commit into
edgehog-device-manager:main
Choose a base branch
from
lusergit:push-tvsxwnulrllr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6caad7f to
8dd2ea5
Compare
e88f72b to
6628db5
Compare
e9161dd to
7544fe4
Compare
davidebriani
requested changes
Oct 29, 2025
| - uses: mshick/add-pr-comment@v2 | ||
| with: | ||
| message: | | ||
| **⚠️ This PR chenges migrations and/or snapshots** |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| **⚠️ This PR chenges migrations and/or snapshots** | |
| **⚠️ This PR changes migrations and/or snapshots** |
| with: | ||
| message: | | ||
| **⚠️ This PR chenges migrations and/or snapshots** | ||
| Ensure that it is are based on the latest changes in the base branch before merging. |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Ensure that it is are based on the latest changes in the base branch before merging. | |
| Ensure that the changes are based on the latest revision of the target branch before merging. Migrations and snapshots are timestamp-based and should chronologically follow the ones already merged. |
625b953 to
2335d6d
Compare
7ee1b99 to
4db3c83
Compare
19b6f20 to
40fe7b3
Compare
b28bcb7 to
c087119
Compare
d522744 to
eac6bae
Compare
Whane a new PR that touches migrations is made, an action is triggered to signal the reviewer: PRs that handle migrations should be merged carefully, as they need to run accordingly to the state of the repo. Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
eac6bae to
64a6d2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to avoid making mistakes when merging a new action in the CI checks if some changes are made to migrations, signaling the reviewer (and the merger) to pay attention to them.