Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 6, 2025

Briefly, what does this PR introduce?

This PR modifies the way the spack-package repo is added to the container. Instead of putting the repo in the container with a specific git clone, we now use the new spack repo add command which retains the information that this is a repository and which then supports spack repo update. When spack only knows of a directory (previous situation), there is nothing to update.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc
Copy link
Contributor Author

This PR turns out to be harder than anticipated. When using spack repo add you lose the .git dir and its history. Since we apply cherry-picks, we need that history.

This has been passed to the spack team as a suggestion.

@wdconinc
Copy link
Contributor Author

We may be able to do this with a spack repo update --commit for every commit, to fill the history in the shallow commit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants