Skip to content

material_scan: move output so it's uploaded to artifact #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

material_scan: move output so it's uploaded to artifact #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89eeeff
material_scan: move output so it's uploaded to artifact
veprbl Nov 3, 2025
658dc3f
Merge branch 'master' into pr/material_scan_fix
veprbl Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions benchmarks/material_scan/Snakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ rule material_scan:
input:
script="material_scan.py",
output:
"{DETECTOR_CONFIG}/results/material_scan.png",
"{DETECTOR_CONFIG}/results/material_scan_agg.csv",
"{DETECTOR_CONFIG}/results/material_scan_details.pdf",
"results/material_scan/{DETECTOR_CONFIG}/material_scan.png",
"results/material_scan/{DETECTOR_CONFIG}/material_scan_agg.csv",
"results/material_scan/{DETECTOR_CONFIG}/material_scan_details.pdf",
log:
"{DETECTOR_CONFIG}/results/material_scan.log",
"results/material_scan/{DETECTOR_CONFIG}/material_scan.log",
shadow: "full" # avoid putting calibrations/fieldmaps to results
shell: """
cd {wildcards.DETECTOR_CONFIG}/results
python ../../{input.script} $DETECTOR_PATH/{wildcards.DETECTOR_CONFIG}.xml
cd results/material_scan/{wildcards.DETECTOR_CONFIG}
python ../../../{input.script} $DETECTOR_PATH/{wildcards.DETECTOR_CONFIG}.xml
"""
2 changes: 1 addition & 1 deletion benchmarks/material_scan/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bench:material_scan:
extends: .det_benchmark
stage: benchmarks
script:
- snakemake $SNAKEMAKE_FLAGS --cores 1 epic_craterlake/results/material_scan_details.pdf
- snakemake $SNAKEMAKE_FLAGS --cores 1 results/material_scan/epic_craterlake/material_scan_details.pdf

collect_results:material_scan:
extends: .det_benchmark
Expand Down