Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Mar 27, 2025

What

Support:

  • lint on linux and windows
  • test on linux and windows
  • update

Add dependabot

Use github composite action for setting up the environment

Skip failures on Windows-2025

Why

This project uses an old version of golang/magefile that requires further changes or an update in the BK images. See #129

It seems more trivial and easy to use GH actions instead. See 8784ed3 (#130) versus https://github.com/elastic/elastic-agent-client/pull/130/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

Faster builds:

image

vs

image

and it added the OS windows

Part of #120

@v1v v1v requested review from a team March 27, 2025 10:51
@v1v v1v self-assigned this Mar 27, 2025
@v1v v1v marked this pull request as ready for review March 27, 2025 10:51
@v1v v1v requested a review from a team as a code owner March 27, 2025 10:51
@v1v v1v requested review from pchila and ycombinator and removed request for a team March 27, 2025 10:51
@v1v v1v mentioned this pull request Mar 27, 2025
@v1v v1v marked this pull request as draft March 27, 2025 11:18
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@v1v v1v marked this pull request as ready for review March 27, 2025 11:26
@v1v v1v requested a review from cmacknz March 27, 2025 15:44
@v1v v1v merged commit c525c13 into elastic:main Mar 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants