Raise on recursive macros (#9111)

Closes #9101.

Author: José Valim

lib/elixir/lib/module/locals_tracker.ex

@@ -33,10 +33,7 @@ defmodule Module.LocalsTracker do
   """
   def add_local({_set, bag}, from, to, meta, macro_dispatch?)
       when is_tuple(from) and is_tuple(to) and is_boolean(macro_dispatch?) do
-    if from != to do
-      put_edge(bag, {:local, from}, {to, get_line(meta), macro_dispatch?})
-    end
-
+    put_edge(bag, {:local, from}, {to, get_line(meta), macro_dispatch?})
     :ok
   end
 
@@ -114,16 +111,22 @@ defmodule Module.LocalsTracker do
     :lists.usort(undefined)
   end
 
-  defp undefined_local_error(set, local, macro_dispatch?) do
-    case :ets.lookup(set, {:def, local}) do
-      [] ->
-        :undefined_function
+  defp undefined_local_error(set, local, true) do
+    case :ets.member(set, {:def, local}) do
+      true -> false
+      false -> :undefined_function
+    end
+  end
 
-      [{_, kind, _, _, _, _}] when kind in @defmacros and not macro_dispatch? ->
+  defp undefined_local_error(set, local, false) do
+    try do
+      if :ets.lookup_element(set, {:def, local}, 2) in @defmacros do
         :incorrect_dispatch
-
-      _ ->
+      else
         false
+      end
+    catch
+      _, _ -> :undefined_function
     end
   end
 

lib/elixir/src/elixir_locals.erl

@@ -25,8 +25,8 @@ yank(Tuple, Module) ->
 reattach(Tuple, Kind, Module, Function, Neighbours, Meta) ->
   if_tracker(Module, fun(Tracker) -> ?tracker:reattach(Tracker, Tuple, Kind, Function, Neighbours, Meta) end).
 
-record_local(Tuple, _Module, Function, _Meta, _IsMacroDispatch)
-  when Function == nil; Function == Tuple -> ok;
+record_local(_Tuple, _Module, nil, _Meta, _IsMacroDispatch) ->
+  ok;
 record_local(Tuple, Module, Function, Meta, IsMacroDispatch) ->
   if_tracker(Module, fun(Tracker) -> ?tracker:add_local(Tracker, Function, Tuple, Meta, IsMacroDispatch), ok end).
 

lib/elixir/test/elixir/kernel/errors_test.exs

@@ -738,6 +738,14 @@ defmodule Kernel.ErrorsTest do
                         defmacrop bar, do: :ok
                       end
                       '''
+
+    assert_eval_raise CompileError,
+                      "nofile:2: cannot invoke macro bar/1 before its definition",
+                      '''
+                      defmodule Kernel.ErrorsTest.IncorrectMacroDispatch do
+                        defmacro bar(a) when is_atom(a), do: bar([a])
+                      end
+                      '''
   end
 
   test "macro captured before its definition" do