Skip to content

Conversation

@coremore35
Copy link

This pull request updates several tutorial and guide files to improve clarity, accessibility, and keep content up to date with external changes. The most significant changes include updating terminology and links related to Twitter (now X), improving instructions and descriptions for accessibility, and fixing minor grammatical and formatting issues.

Terminology and External References Updates

  • Replaced references to "Twitter" with "X (formerly Twitter)" throughout the tutorial, including updating API documentation links, button labels, and descriptive text. This ensures the guides reflect the current branding and API location for X. [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated a link to JavaScript feature documentation from ponyfoo.com to web.dev for a more current and authoritative resource.

Accessibility and Instruction Improvements

  • Improved the description of code diffs in the tutorial to clarify that removed lines are highlighted in red and added lines in green, enhancing accessibility for users with screen readers.
  • Added colons to command instructions and step descriptions for clarity and consistency in deployment and setup guides. [1] [2] [3]

Formatting and Grammar Fixes

  • Changed "2 ways" to "two ways" for grammatical correctness.
  • Updated several sentences to end with periods or colons for improved readability and consistency in deployment instructions.

Code and Component Naming Consistency

  • Updated component references and code block language identifiers for accuracy and consistency, such as changing Rentals::Filter to RentalsFilter and using gjs instead of js or handlebars. [1] [2] [3] [4] [5]

These changes collectively improve the accuracy, clarity, and accessibility of the guides and tutorials.

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit acb5d94
🔍 Latest deploy log https://app.netlify.com/projects/ember-guides/deploys/6920944c7668af0008fc0470
😎 Deploy Preview https://deploy-preview-2178--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IgnaceMaes
Copy link
Member

Lovely, thanks!

But: tutorial changes are managed in a separate repo (https://github.com/ember-learn/super-rentals-tutorial/blob/master/src/markdown/tutorial/part-1/04-component-basics.md)

Would you be able to open a PR there? As otherwise they will get overwritten in this repo later. (cfr first line in each file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants