From 1402359489bb65f12dc2fc957f62321cc7ccd807 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Fri, 31 Oct 2025 20:00:32 -0700 Subject: [PATCH] Remove unused argument from autoResumeAudioContext This fixes a TODO from 2022. --- src/lib/libcore.js | 11 ++--------- test/codesize/test_codesize_hello_dylink_all.json | 4 ++-- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/lib/libcore.js b/src/lib/libcore.js index cb785ec66ae98..64d153ebbd826 100644 --- a/src/lib/libcore.js +++ b/src/lib/libcore.js @@ -1711,16 +1711,9 @@ addToLibrary({ // input events on, and registers a context resume() for them. This lets // audio work properly in an automatic way, as browsers won't let audio run // without user interaction. - // If @elements is not provided, we default to the document and canvas - // elements, which handle common use cases. - // TODO(sbc): Remove seemingly unused elements argument - $autoResumeAudioContext__docs: '/** @param {Array=} elements */', - $autoResumeAudioContext: (ctx, elements) => { - if (!elements) { - elements = [document, document.getElementById('canvas')]; - } + $autoResumeAudioContext: (ctx) => { for (var event of ['keydown', 'mousedown', 'touchstart']) { - for (var element of elements) { + for (var element of [document, document.getElementById('canvas')]) { element?.addEventListener(event, () => { if (ctx.state === 'suspended') ctx.resume(); }, { 'once': true }); diff --git a/test/codesize/test_codesize_hello_dylink_all.json b/test/codesize/test_codesize_hello_dylink_all.json index e9fad153d2f97..a0672f5244635 100644 --- a/test/codesize/test_codesize_hello_dylink_all.json +++ b/test/codesize/test_codesize_hello_dylink_all.json @@ -1,7 +1,7 @@ { - "a.out.js": 245496, + "a.out.js": 245483, "a.out.nodebug.wasm": 574067, - "total": 819563, + "total": 819550, "sent": [ "IMG_Init", "IMG_Load",