index: reorganize exports #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
force-pushed
the
index-reorganize-exports
branch
3 times, most recently
from
95a5578 to
02c5283
Compare
waywardmonkeys
approved these changes
Dec 5, 2025
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
We'll need to further revise the docs ... but we can deal with that later.
On `main`, almost everything is both exported publicly inside its own
module as well as re-exported at the top-level. I've reorganized the
exports such that everything is exported only at the top-level, except
for the backends.
For the backends, we may want to remove the type alias re-exports and
export everything once under `understory_index::backends` (so we'd have
`understory_index::backends::{Bvh, BvhF32, FlatVec, ...}`).
Alternatively, we could simply also export all the backend stuff at the
top-level.
tomcur
force-pushed
the
index-reorganize-exports
branch
from
02c5283 to
60d5b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
main, almost everything is both exported publicly inside its own module as well as re-exported at the top-level. I've reorganized the exports such that everything is exported only at the top-level, except for the backends.For the backends, this suggests removing the type alias re-exports and exports everything once under
understory_index::backends(so we'd haveunderstory_index::backends::{Bvh, BvhF32, FlatVec, ...}).Alternatively, we could simply export all the backend stuff at the top-level.