Remove reference to paginationOption in getOptionLabel

Author: ericgio

src/components/Typeahead/Typeahead.test.tsx

@@ -325,12 +325,7 @@ describe('<Typeahead>', () => {
 
     it('calls `onPaginate` when `labelKey` is a function', async () => {
       const user = userEvent.setup();
-      render(
-        <Pagination
-          labelKey={(o) => (o as Option).name}
-          onPaginate={onPaginate}
-        />
-      );
+      render(<Pagination labelKey={() => 'label'} onPaginate={onPaginate} />);
 
       getInput().focus();
       await user.keyboard('{ArrowUp}{Enter}');

src/components/TypeaheadMenu/TypeaheadMenu.stories.tsx

@@ -41,7 +41,7 @@ CustomOption.args = {
 export const Pagination = Template.bind({});
 Pagination.args = {
   ...defaultProps,
-  options: [...options.slice(0, 5), { paginationOption: true }],
+  options: [...options.slice(0, 5), { name: '', paginationOption: true }],
 };
 
 export const CustomChildren = Template.bind({});

src/utils/getOptionLabel.test.ts

@@ -31,7 +31,7 @@ describe('getOptionLabel', () => {
     };
 
     const paginationOption = {
-      [getStringLabelKey(labelKeyFn)]: 'bar',
+      name: 'bar',
       paginationOption: true,
     };
 
@@ -47,12 +47,12 @@ describe('getOptionLabel', () => {
 
   it('throws an error when an invalid option is encountered', () => {
     const willThrow = () => getOptionLabel([], 'name');
-    expect(willThrow).toThrowError(Error);
+    expect(willThrow).toThrow(Error);
   });
 
   it('throws an error when `option` is an object and no labelkey is specified', () => {
     // @ts-expect-error
     const willThrow = () => getOptionLabel(option);
-    expect(willThrow).toThrowError(Error);
+    expect(willThrow).toThrow(Error);
   });
 });

src/utils/getOptionLabel.ts

@@ -13,11 +13,7 @@ import type { LabelKey, Option } from '../types';
  */
 function getOptionLabel(option: Option, labelKey: LabelKey): string {
   // Handle internally created options first.
-  if (
-    !isString(option) &&
-    (hasOwnProperty(option, 'paginationOption') ||
-      hasOwnProperty(option, 'customOption'))
-  ) {
+  if (!isString(option) && hasOwnProperty(option, 'customOption')) {
     return option[getStringLabelKey(labelKey)] as string;
   }