-
Notifications
You must be signed in to change notification settings - Fork 202
Closed
Description
Is your feature request related to a problem? Please describe.
We have try the newest main branch (0fb0dcbefc50882f1bb02fafcb27f47b463875c9) to test whether it can support the chain which is generated by op-contracts/v2.0.0-beta.2
Our chain is using:
- custom gas token
- op-plasma with
KeccakCommitment - isFraudProof is
false
Describe the solution you'd like
can let the deploy-config in op-contracts/v2.0.0-beta.2 work well
Describe alternatives you've considered
For now we can only modify local code, but can not pass the ci. And a related issue is:
ethereum-optimism/optimism#11185 (comment)
Additional context
In our test, the issue at least contains:
- in
getting-started/.deployaddress json file, we should addFaultDisputeGamePermissionedDisputeGamein manual, which should contain in the rollup.json when execute the script inop-contracts/v2.0.0-beta.2, so it's a bug in this value - also in this json file, we need to delete
AnchorStateRegistryandAnchorStateRegistryProxywhich is a bed condition in this repo to judge whether it usesFraudProof - op side advice us to config
Eip1559Elasticityto10, but incheck-genesisstep, it requires us to set 6:

- for custome gas token, when this contract is version
op-contracts/v2.0.0-beta.2. :superchain-registry/add-chain/main.go
Lines 206 to 212 in c971994
result, err := sc.GasPayingToken(&opts) if strings.Contains(err.Error(), "execution reverted") { // This happens when the SystemConfig contract // does not yet have the CGT functionality. return nil, nil }
L206errwill benil, but in L208, theerr.Error()will panic due tonull pointer - when using op-plasma the rollup check will meet
, related to issue When use GenericCommitmentin alt-da, some logic is useless or incorrect in op-node optimism#11185 (comment), meanwhile, it's better if the legency field can use old value, rather then must set them to default/0 value
geoknee
Metadata
Metadata
Assignees
Labels
No labels