Skip to content

Evergreen log access clarity #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sophstad wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Evergreen log access clarity #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fd177b
feat: improve Evergreen UI log access clarity
cursoragent Jan 15, 2026
9fa4747
test: update Cypress tests for Event Log button changes
cursoragent Jan 15, 2026
a014e8a
fix: update error message to use 'combined logs' terminology
cursoragent Jan 15, 2026
bdff3c9
refactor: address PR feedback for log access clarity
cursoragent Jan 16, 2026
69010ed
feat: restore Event Log as standalone button
cursoragent Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 23 additions & 28 deletions apps/spruce/cypress/integration/task/task_logs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ describe("task logs", () => {
const taskLogsButton = 'button[id="cy-task-option"]';
const agentLogsButton = 'button[id="cy-agent-option"]';
const systemLogsButton = 'button[id="cy-system-option"]';
const eventLogsButton = 'button[id="cy-event-option"]';
const allLogsButton = 'button[id="cy-all-option"]';
const eventLogsButton = 'button[data-cy="cy-event-option"]';

beforeEach(() => {
cy.visit(LOGS_ROUTE);
Expand Down Expand Up @@ -51,16 +51,6 @@ describe("task logs", () => {
);
});

it("Event logs should not have an HTML button, Raw button, or Parsley button", () => {
cy.get(eventLogsButton).click({ force: true });
cy.get(eventLogsButton)
.should("have.attr", "aria-selected")
.and("eq", "true");
cy.dataCy("html-log-btn").should("not.exist");
cy.dataCy("raw-log-btn").should("not.exist");
cy.dataCy("parsley-log-btn").should("not.exist");
});

it("Should update logtype query param to agent after checking agent radio button", () => {
cy.get(agentLogsButton).click({ force: true });
cy.get(agentLogsButton)
Expand All @@ -72,17 +62,6 @@ describe("task logs", () => {
});
});

it("Should update logtype query param to event after checking event radio button", () => {
cy.get(eventLogsButton).click({ force: true });
cy.get(eventLogsButton)
.should("have.attr", "aria-selected")
.and("eq", "true");
cy.location().should((loc) => {
expect(loc.pathname).to.equal(LOGS_ROUTE);
expect(loc.search).to.include("logtype=event");
});
});

it("Should update logtype query param to system after checking system radio button", () => {
cy.get(systemLogsButton).click({ force: true });
cy.get(systemLogsButton)
Expand All @@ -105,6 +84,21 @@ describe("task logs", () => {
});
});

it("Event logs button should not show Parsley, HTML, or Raw buttons", () => {
cy.get(eventLogsButton).click({ force: true });
cy.dataCy("html-log-btn").should("not.exist");
cy.dataCy("raw-log-btn").should("not.exist");
cy.dataCy("parsley-log-btn").should("not.exist");
});

it("Should update logtype query param to event after clicking event button", () => {
cy.get(eventLogsButton).click({ force: true });
cy.location().should((loc) => {
expect(loc.pathname).to.equal(LOGS_ROUTE);
expect(loc.search).to.include("logtype=event");
});
});

it("Should initially load with task log radio checked when logtype query param is task", () => {
cy.visit(`${LOGS_ROUTE}?logtype=task`);
cy.get(taskLogsButton)
Expand All @@ -129,18 +123,19 @@ describe("task logs", () => {
.should("have.attr", "aria-selected")
.and("eq", "true");
});
it("Should initially load with event log radio checked when logtype query param is event", () => {
cy.visit(`${LOGS_ROUTE}?logtype=event`);
cy.get(eventLogsButton)
.should("have.attr", "aria-selected")
.and("eq", "true");
});
it("Should initially load with all log radio checked when logtype query param is all", () => {
cy.visit(`${LOGS_ROUTE}?logtype=all`);
cy.get(allLogsButton)
.should("have.attr", "aria-selected")
.and("eq", "true");
});
it("Should initially load with event log when logtype query param is event", () => {
cy.visit(`${LOGS_ROUTE}?logtype=event`);
cy.get(eventLogsButton).should("exist");
cy.location().should((loc) => {
expect(loc.search).to.include("logtype=event");
});
});
});

describe("HTML log viewer", () => {
Expand Down
255 changes: 0 additions & 255 deletions apps/spruce/src/pages/task/taskTabs/logs/LogTypes.tsx
View file
Open in desktop

This file was deleted.

Loading