Skip to content

Few formating and modifications to your paper text#23

Merged
everval merged 4 commits intoeverval:masterfrom
lrnv:patch-1
Mar 31, 2025
Merged

Few formating and modifications to your paper text#23
everval merged 4 commits intoeverval:masterfrom
lrnv:patch-1

Conversation

@lrnv
Copy link
Contributor

@lrnv lrnv commented Mar 31, 2025

hey !

Just a few proposal to reformat / rewrite your paper, please take whatever chances you like and discard what you do not like nothing is mandatory.

  • I removed the fully extended citations in the example of research conducted with LogMemory.jl since they are expanded in the biliography right after.
  • I replaced $\approx$ by $\sim$ for equivalences of functions: if you prefer $\approx$ and in particular if it used all over your documentation, please keep $\approx$, but note that $\sim$ is more standard for what you meant.
  • I tried to make the table easier to read, not sure i succeded ^^

However, one ask: on line 54, after "Generating methods include fractional differencing, stochastic error duration, and cross-sectional aggregation.", it would be great to add a citation. Maybe there exists some standard book ?

ref: openjournals/joss-reviews#7708 (comment)

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Owner

@everval everval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally liked the changes, just a correction on the values of d. It should be an open interval, so I took the suggested change to make it clearer. The table looks much better, and I like to shorten the last section. As for the textbook reference, the standard one is Beran et all 2013 in line 23. Do you think it is worthwhile to repeat it for clarity?

@everval everval merged commit 4165c43 into everval:master Mar 31, 2025
@lrnv
Copy link
Contributor Author

lrnv commented Mar 31, 2025

Hum.. I was debating wether you should repeat the textbook ref, taking into account that I am not a specialist and that anyone reading this should already know what is happening : in fact the policy is that Joss papers are written for non specialists, so yes you could repeat it.

Sorry for the mistake on $d$ !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants