Skip to content

Conversation

@gsalsero
Copy link
Contributor

@gsalsero gsalsero commented Feb 24, 2025

  1. After downloading multiple ftp log files. Process each one.
  2. Added log line to notify what file is being processed.

@evilru
Copy link
Owner

evilru commented Feb 25, 2025

would you mind to split this into two pr?

  • I would merge the ereg > preg_match fix immediately.
  • the ftp related change might need a bit more of my time

cheers

@gsalsero
Copy link
Contributor Author

would you mind to split this into two pr?

  • I would merge the ereg > preg_match fix immediately.
  • the ftp related change might need a bit more of my time

cheers

No problem.

@gsalsero
Copy link
Contributor Author

would you mind to split this into two pr?

  • I would merge the ereg > preg_match fix immediately.
  • the ftp related change might need a bit more of my time

cheers

No problem.

I reverted the ereg change a submitted a new PR for that. #24

@evilru
Copy link
Owner

evilru commented Mar 13, 2025

Could you please explain the requirement for this change? It is labeled as a fix, but it appears to be more like a new feature. The purpose and necessity of this change are not entirely clear to me.

Could you provide more details on what you are trying to add and why it is needed?

Best

@gsalsero
Copy link
Contributor Author

Could you please explain the requirement for this change? It is labeled as a fix, but it appears to be more like a new feature. The purpose and necessity of this change are not entirely clear to me.

Could you provide more details on what you are trying to add and why it is needed?

Best

Perhaps I misunderstood the functionality it provided. I based this fix on this:

https://github.com/evilru/quake3-vsp-stats/blob/71aa0efd2045a5fc27dcbd62eddaa98f6f1dee7e/readme.txt#L510C8-L510C16

- fix: Improved ftp remote downloading of logs. You can now specify a directory
       or a single file to download. If the ftp path supplied by the user ends 
       with a / or a \, then its assumed to be a directory and all the files 
       inside that directory will be downloaded (non-recursive). So remote 
       downloading of logs should work properly with games like Half life which 
       has separate logs for each game.

I assumed after all the logs were downloaded it would process them all. That wasn't happening so I modified the code to do so. If this is a new feature rather than a bug fix, I'm fine with that change.

@evilru
Copy link
Owner

evilru commented Mar 27, 2025

Thank you for pointing out this missing functionality. It should have been included initially, and I appreciate your effort in identifying it. Although I've reviewed it, I haven't had the chance to merge it yet.

Thanks again for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants