-
Notifications
You must be signed in to change notification settings - Fork 12
Ftp dir download fix #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
would you mind to split this into two pr?
cheers |
No problem. |
I reverted the |
|
Could you please explain the requirement for this change? It is labeled as a fix, but it appears to be more like a new feature. The purpose and necessity of this change are not entirely clear to me. Could you provide more details on what you are trying to add and why it is needed? Best |
Perhaps I misunderstood the functionality it provided. I based this fix on this: I assumed after all the logs were downloaded it would process them all. That wasn't happening so I modified the code to do so. If this is a new feature rather than a bug fix, I'm fine with that change. |
|
Thank you for pointing out this missing functionality. It should have been included initially, and I appreciate your effort in identifying it. Although I've reviewed it, I haven't had the chance to merge it yet. Thanks again for your contribution! ❤️ |
Uh oh!
There was an error while loading. Please reload this page.