Skip to content

Commit 5d0cf98

Browse files
anand1976meta-codesync[bot]
authored andcommitted
Surface MultiScan async read failure instead of asserting (facebook#14171)
Summary: Crash tests have been failing of late with this assertion failure - db_stress: `./table/block_based/block_based_table_iterator.h:656: void rocksdb::BlockBasedTableIterator::PrepareReadAsyncCallBack(rocksdb::FSReadRequest &, void *): Assertion `async_state->status.IsAborted()' failed.` Instead of asserting, surface the failure status so we can troubleshoot. Pull Request resolved: facebook#14171 Reviewed By: xingbowang Differential Revision: D88396654 Pulled By: anand1976 fbshipit-source-id: 8d59d7ace0c522c17b7af17c50e16af876911bad
1 parent e3b5464 commit 5d0cf98

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

table/block_based/block_based_table_iterator.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -652,8 +652,6 @@ class BlockBasedTableIterator : public InternalIteratorBase<Slice> {
652652
std::to_string(async_state->offset) + " and async callback " +
653653
std::to_string(req.offset));
654654
}
655-
} else {
656-
assert(async_state->status.IsAborted());
657655
}
658656
}
659657

0 commit comments

Comments
 (0)