Review feedback

alpe · alpe · commit 0b927a34db06 · 2025-12-22T13:21:32.000+01:00
diff --git a/block/internal/syncing/da_retriever.go b/block/internal/syncing/da_retriever.go
@@ -271,12 +271,6 @@ func (r *daRetriever) tryDecodeHeader(bz []byte, daHeight uint64) *types.SignedH
 			}
 			r.logger.Debug().Uint64("height", header.Height()).Msg("DA envelope signature verified")
 			isValidEnvelope = true
-		} else {
-			// No signature in envelope? Treat as legacy or invalid.
-			if r.strictMode {
-				r.logger.Warn().Msg("strict mode is enabled, rejecting envelope without signature")
-				return nil
-			}
 		}
 	}
 	if r.strictMode && !isValidEnvelope {

Original file line number	Diff line number	Diff line change
`@@ -271,12 +271,6 @@ func (r daRetriever) tryDecodeHeader(bz []byte, daHeight uint64) types.SignedH`
`271`	`271`	`}`
`272`	`272`	`r.logger.Debug().Uint64("height", header.Height()).Msg("DA envelope signature verified")`
`273`	`273`	`isValidEnvelope = true`
`274`		`- } else {`
`275`		`- // No signature in envelope? Treat as legacy or invalid.`
`276`		`- if r.strictMode {`
`277`		`- r.logger.Warn().Msg("strict mode is enabled, rejecting envelope without signature")`
`278`		`- return nil`
`279`		`- }`
`280`	`274`	`}`
`281`	`275`	`}`
`282`	`276`	`if r.strictMode && !isValidEnvelope {`