Skip to content

Commit 24732a9

Browse files
Copilotjulienrbrt
andcommitted
Address pruner review feedback
Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>
1 parent dbc8eb1 commit 24732a9

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

block/internal/pruner/pruner.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ type Pruner struct {
4141
}
4242

4343
// New creates a new Pruner instance.
44-
func New(store store.Store, execPruner ExecMetaPruner, retention uint64, interval time.Duration, logger zerolog.Logger) *Pruner {
44+
func New(store store.Store, execMetaPruner ExecMetaPruner, retention uint64, interval time.Duration, logger zerolog.Logger) *Pruner {
4545
if interval <= 0 {
4646
interval = DefaultPruneInterval
4747
}
@@ -56,7 +56,7 @@ func New(store store.Store, execPruner ExecMetaPruner, retention uint64, interva
5656
return &Pruner{
5757
store: store,
5858
stateDeleter: deleter,
59-
execPruner: execPruner,
59+
execPruner: execMetaPruner,
6060
retention: retention,
6161
interval: interval,
6262
logger: logger,
@@ -126,7 +126,7 @@ func (p *Pruner) pruneOnce(ctx context.Context) error {
126126

127127
target := height - p.retention
128128
if target < p.lastPruned {
129-
p.lastPruned = target
129+
p.lastPruned = 0
130130
return nil
131131
}
132132
if target == p.lastPruned {

execution/evm/store_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,4 @@ func TestDeleteExecMeta(t *testing.T) {
2525
meta, err := store.GetExecMeta(ctx, 1)
2626
require.NoError(t, err)
2727
require.Nil(t, meta)
28-
29-
require.NoError(t, store.DeleteExecMeta(ctx, 1))
3028
}

0 commit comments

Comments
 (0)