Merge branch 'cian/experiment-with-granularspans' into cian/update-ev-reth-spans

Author: chatton

.github/workflows/benchmark.yml

@@ -84,9 +84,11 @@ jobs:
         uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
         with:
           name: spamoor-benchmark-results
+          path: test/e2e/
 
       # only update the benchmark baseline on push/dispatch, not on PRs
       - name: Store EVM Contract Roundtrip result
+        if: always()
         uses: benchmark-action/github-action-benchmark@4bdcce38c94cec68da58d012ac24b7b1155efe8b # v1.20.7
         with:
           name: EVM Contract Roundtrip
@@ -101,9 +103,11 @@ jobs:
 
       # delete local gh-pages so the next benchmark action step fetches fresh from remote
       - name: Reset local gh-pages branch
+        if: always()
         run: git branch -D gh-pages || true
 
       - name: Store Block Executor result
+        if: always()
         uses: benchmark-action/github-action-benchmark@4bdcce38c94cec68da58d012ac24b7b1155efe8b # v1.20.7
         with:
           name: Block Executor Benchmark
@@ -118,9 +122,11 @@ jobs:
 
       # delete local gh-pages so the next benchmark action step fetches fresh from remote
       - name: Reset local gh-pages branch
+        if: always()
         run: git branch -D gh-pages || true
 
       - name: Store Spamoor Trace result
+        if: always()
         uses: benchmark-action/github-action-benchmark@4bdcce38c94cec68da58d012ac24b7b1155efe8b # v1.20.7
         with:
           name: Spamoor Trace Benchmarks
@@ -130,5 +136,5 @@ jobs:
           save-data-file: ${{ github.event_name != 'pull_request' }}
           github-token: ${{ secrets.GITHUB_TOKEN }}
           alert-threshold: '150%'
-          fail-on-alert: true
+          fail-on-alert: false
           comment-on-alert: true

test/e2e/evm_test_common.go

@@ -967,8 +967,6 @@ func writeTraceBenchmarkJSON(t testing.TB, label string, spans []traceSpan, outp
 		avg := float64(s.total.Microseconds()) / float64(s.count)
 		entries = append(entries,
 			benchmarkEntry{Name: fmt.Sprintf("%s - %s (avg)", label, name), Unit: "us", Value: avg},
-			benchmarkEntry{Name: fmt.Sprintf("%s - %s (min)", label, name), Unit: "us", Value: float64(s.min.Microseconds())},
-			benchmarkEntry{Name: fmt.Sprintf("%s - %s (max)", label, name), Unit: "us", Value: float64(s.max.Microseconds())},
 		)
 	}