bump

Author: julienrbrt

pkg/da/app/client.go

@@ -155,7 +155,8 @@ func (c *Client) Retrieve(ctx context.Context, height uint64, namespace []byte)
 	// Fetch block from celestia-app
 	blockResult, err := c.getBlock(ctx, height)
 	if err != nil {
-		// Handle specific errors
+		// Handle specific errors returned by the CometBFT RPC
+		// If the node is requesting a block that is in the future, we return StatusHeightFromFuture
 		if strings.Contains(err.Error(), "height") && strings.Contains(err.Error(), "future") {
 			return datypes.ResultRetrieve{
 				BaseResult: datypes.BaseResult{
@@ -166,6 +167,9 @@ func (c *Client) Retrieve(ctx context.Context, height uint64, namespace []byte)
 				},
 			}
 		}
+
+		// Handle pruned blocks from CometBFT. The underlying error contains:
+		// "height X is not available, lowest height is Y"
 		if strings.Contains(err.Error(), "is not available, lowest height is") {
 			c.logger.Debug().Uint64("height", height).Err(err).Msg("block is pruned or unavailable")
 			return datypes.ResultRetrieve{

pkg/da/app/client_test.go

@@ -495,14 +495,22 @@ func TestRPCCall(t *testing.T) {
 }
 
 func TestRPCTypes(t *testing.T) {
-	t.Run("rpcError Error() method", func(t *testing.T) {
+	t.Run("rpcError Error() method with data", func(t *testing.T) {
 		err := &rpcError{
 			Code:    -32600,
 			Message: "Invalid Request",
 			Data:    "extra data",
 		}
 		assert.Equal(t, "RPC error -32600: Invalid Request: extra data", err.Error())
 	})
+
+	t.Run("rpcError Error() method without data", func(t *testing.T) {
+		err := &rpcError{
+			Code:    -32603,
+			Message: "Internal error",
+		}
+		assert.Equal(t, "RPC error -32603: Internal error", err.Error())
+	})
 }
 
 func TestClient_InterfaceCompliance(t *testing.T) {