comments

Author: julienrbrt

block/internal/syncing/syncer.go

@@ -29,12 +29,6 @@ type daHandler interface {
 }
 
 // Syncer handles block synchronization from DA and P2P sources.
-// It is responsible for:
-// - Retrieving blocks from DA layer
-// - Retrieving blocks from P2P network
-// - Validating and applying blocks to update state
-// - Tracking DA inclusion for finality
-// Note: DA submission is handled by the Executor, not the Syncer
 type Syncer struct {
 	// Core components
 	store store.Store
@@ -83,10 +77,6 @@ type Syncer struct {
 	wg     sync.WaitGroup
 }
 
-// HeightEvent represents a block height event with header and data
-// This is an alias to the common.HeightEvent type for backward compatibility
-type HeightEvent = common.HeightEvent
-
 // NewSyncer creates a new block syncer
 func NewSyncer(
 	store store.Store,
@@ -114,7 +104,7 @@ func NewSyncer(
 		dataStore:     dataStore,
 		lastStateMtx:  &sync.RWMutex{},
 		daStateMtx:    &sync.RWMutex{},
-		heightInCh:    make(chan HeightEvent, 10000),
+		heightInCh:    make(chan common.HeightEvent, 10000),
 		headerStoreCh: make(chan struct{}, 1),
 		dataStoreCh:   make(chan struct{}, 1),
 		daIncluderCh:  make(chan struct{}, 1),

block/internal/syncing/syncer_logic_test.go

@@ -109,7 +109,7 @@ func TestProcessHeightEvent_SyncsAndUpdatesState(t *testing.T) {
 	mockExec.EXPECT().ExecuteTxs(mock.Anything, mock.Anything, uint64(1), mock.Anything, lastState.AppHash).
 		Return([]byte("app1"), uint64(1024), nil).Once()
 
-	evt := HeightEvent{Header: hdr, Data: data, DaHeight: 1}
+	evt := common.HeightEvent{Header: hdr, Data: data, DaHeight: 1}
 	s.processHeightEvent(&evt)
 
 	h, err := st.Height(context.Background())
@@ -155,7 +155,7 @@ func TestDAInclusion_AdvancesHeight(t *testing.T) {
 	// Expect ExecuteTxs call for height 1
 	mockExec.EXPECT().ExecuteTxs(mock.Anything, mock.Anything, uint64(1), mock.Anything, st0.AppHash).
 		Return([]byte("app1"), uint64(1024), nil).Once()
-	evt1 := HeightEvent{Header: hdr1, Data: data1, DaHeight: 10}
+	evt1 := common.HeightEvent{Header: hdr1, Data: data1, DaHeight: 10}
 	s.processHeightEvent(&evt1)
 
 	st1, _ := st.GetState(context.Background())
@@ -164,7 +164,7 @@ func TestDAInclusion_AdvancesHeight(t *testing.T) {
 	// Expect ExecuteTxs call for height 2
 	mockExec.EXPECT().ExecuteTxs(mock.Anything, mock.Anything, uint64(2), mock.Anything, st1.AppHash).
 		Return([]byte("app2"), uint64(1024), nil).Once()
-	evt2 := HeightEvent{Header: hdr2, Data: data2, DaHeight: 11}
+	evt2 := common.HeightEvent{Header: hdr2, Data: data2, DaHeight: 11}
 	s.processHeightEvent(&evt2)
 
 	// Mark DA inclusion in cache (as DA retrieval would)