chore: adding hex encoded namespace

Author: chatton

block/internal/da/tracing.go

@@ -2,6 +2,7 @@ package da
 
 import (
 	"context"
+	"encoding/hex"
 
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
@@ -31,7 +32,7 @@ func (t *tracedClient) Submit(ctx context.Context, data [][]byte, gasPrice float
 		trace.WithAttributes(
 			attribute.Int("blob.count", len(data)),
 			attribute.Int("blob.total_size_bytes", total),
-			attribute.String("da.namespace", string(namespace)),
+			attribute.String("da.namespace", hex.EncodeToString(namespace)),
 		),
 	)
 	defer span.End()
@@ -50,7 +51,7 @@ func (t *tracedClient) Retrieve(ctx context.Context, height uint64, namespace []
 	ctx, span := t.tracer.Start(ctx, "DA.Retrieve",
 		trace.WithAttributes(
 			attribute.Int("ns.length", len(namespace)),
-			attribute.String("da.namespace", string(namespace)),
+			attribute.String("da.namespace", hex.EncodeToString(namespace)),
 		),
 	)
 	defer span.End()
@@ -70,7 +71,7 @@ func (t *tracedClient) Get(ctx context.Context, ids []datypes.ID, namespace []by
 	ctx, span := t.tracer.Start(ctx, "DA.Get",
 		trace.WithAttributes(
 			attribute.Int("id.count", len(ids)),
-			attribute.String("da.namespace", string(namespace)),
+			attribute.String("da.namespace", hex.EncodeToString(namespace)),
 		),
 	)
 	defer span.End()
@@ -89,7 +90,7 @@ func (t *tracedClient) GetProofs(ctx context.Context, ids []datypes.ID, namespac
 	ctx, span := t.tracer.Start(ctx, "DA.GetProofs",
 		trace.WithAttributes(
 			attribute.Int("id.count", len(ids)),
-			attribute.String("da.namespace", string(namespace)),
+			attribute.String("da.namespace", hex.EncodeToString(namespace)),
 		),
 	)
 	defer span.End()
@@ -108,7 +109,7 @@ func (t *tracedClient) Validate(ctx context.Context, ids []datypes.ID, proofs []
 	ctx, span := t.tracer.Start(ctx, "DA.Validate",
 		trace.WithAttributes(
 			attribute.Int("id.count", len(ids)),
-			attribute.String("da.namespace", string(namespace)),
+			attribute.String("da.namespace", hex.EncodeToString(namespace)),
 		),
 	)
 	defer span.End()

block/internal/da/tracing_test.go

@@ -83,22 +83,22 @@ func TestTracedDA_Submit_Success(t *testing.T) {
 	spans := sr.Ended()
 	require.Len(t, spans, 1)
 	span := spans[0]
-    require.Equal(t, "DA.Submit", span.Name())
+	require.Equal(t, "DA.Submit", span.Name())
 	require.Equal(t, codes.Unset, span.Status().Code)
 
-    attrs := span.Attributes()
-    requireAttribute(t, attrs, "blob.count", 2)
-    requireAttribute(t, attrs, "blob.total_size_bytes", 3)
-    // namespace length assertion for local behavior
-    // look for da.namespace and assert byte-length
-    foundNS := false
-    for _, a := range attrs {
-        if string(a.Key) == "da.namespace" {
-            foundNS = true
-            require.Equal(t, 2, len(a.Value.AsString()))
-        }
-    }
-    require.True(t, foundNS, "attribute da.namespace not found")
+	attrs := span.Attributes()
+	requireAttribute(t, attrs, "blob.count", 2)
+	requireAttribute(t, attrs, "blob.total_size_bytes", 3)
+	// namespace hex string length assertion
+	// 2 bytes = 4 hex characters
+	foundNS := false
+	for _, a := range attrs {
+		if string(a.Key) == "da.namespace" {
+			foundNS = true
+			require.Equal(t, 4, len(a.Value.AsString()))
+		}
+	}
+	require.True(t, foundNS, "attribute da.namespace not found")
 }
 
 func TestTracedDA_Submit_Error(t *testing.T) {
@@ -132,10 +132,10 @@ func TestTracedDA_Retrieve_Success(t *testing.T) {
 	spans := sr.Ended()
 	require.Len(t, spans, 1)
 	span := spans[0]
-    require.Equal(t, "DA.Retrieve", span.Name())
-    attrs := span.Attributes()
-    requireAttribute(t, attrs, "ns.length", 1)
-    requireAttribute(t, attrs, "blob.count", 2)
+	require.Equal(t, "DA.Retrieve", span.Name())
+	attrs := span.Attributes()
+	requireAttribute(t, attrs, "ns.length", 1)
+	requireAttribute(t, attrs, "blob.count", 2)
 }
 
 func TestTracedDA_Retrieve_Error(t *testing.T) {
@@ -172,7 +172,7 @@ func TestTracedDA_Get_Success(t *testing.T) {
 	spans := sr.Ended()
 	require.Len(t, spans, 1)
 	span := spans[0]
-    require.Equal(t, "DA.Get", span.Name())
+	require.Equal(t, "DA.Get", span.Name())
 	attrs := span.Attributes()
 	requireAttribute(t, attrs, "id.count", 2)
 	requireAttribute(t, attrs, "blob.count", 2)