Skip to content

Commit 5db30d0

Browse files
author
tac0turtle
committed
lint
1 parent c83f24a commit 5db30d0

File tree

7 files changed

+31
-15
lines changed

7 files changed

+31
-15
lines changed

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11

22
# Changelog
33

4-
54
<!--
65
All notable changes to this module will be documented in this file.
76
@@ -12,26 +11,32 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1211
## [Unreleased]
1312

1413
### Added
14+
1515
<!-- New features or capabilities -->
1616
-
1717

1818
### Changed
19+
1920
<!-- Changes to existing functionality -->
2021
-
2122

2223
### Deprecated
24+
2325
<!-- Features that will be removed in future versions -->
2426
-
2527

2628
### Removed
29+
2730
<!-- Features that were removed -->
2831
-
2932

3033
### Fixed
34+
3135
<!-- Bug fixes -->
3236
-
3337

3438
### Security
39+
3540
<!-- Security vulnerability fixes -->
3641
-
3742

RELEASE.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,14 @@ This document outlines the release process for all Go packages in the Rollkit re
3434
Packages must be released in the following order to ensure dependencies are satisfied:
3535

3636
### Phase 1: Core Package
37+
3738
1. **github.com/rollkit/rollkit/core**
3839
- Path: `./core`
3940
- Dependencies: None (zero-dependency package)
4041
- This is the foundation package containing all interfaces and types
4142

4243
### Phase 2: First-Level Dependencies
44+
4345
These packages only depend on `core` and can be released in parallel after `core`:
4446

4547
2. **github.com/rollkit/rollkit/da**
@@ -55,6 +57,7 @@ These packages only depend on `core` and can be released in parallel after `core
5557
- Dependencies: `rollkit/core`
5658

5759
### Phase 3: Sequencer Packages
60+
5861
These packages depend on both `core` and the main `rollkit` package:
5962

6063
5. **github.com/rollkit/rollkit/sequencers/based**
@@ -66,6 +69,7 @@ These packages depend on both `core` and the main `rollkit` package:
6669
- Dependencies: `rollkit/core`, `rollkit`
6770

6871
### Phase 4: Application Packages
72+
6973
These packages have the most dependencies and should be released last:
7074

7175
7. **github.com/rollkit/rollkit/apps/evm/based**
@@ -108,6 +112,7 @@ go list -m github.com/rollkit/rollkit/core@v<version>
108112
After core is available, update and release modules that only depend on core:
109113

110114
#### 2. Update and release `da` module
115+
111116
```bash
112117
cd da
113118

@@ -124,6 +129,7 @@ go list -m github.com/rollkit/rollkit/da@v<version>
124129
```
125130

126131
#### 3. Update and release main `rollkit` module
132+
127133
```bash
128134
cd . # root directory
129135

@@ -140,6 +146,7 @@ go list -m github.com/rollkit/rollkit@v<version>
140146
```
141147

142148
#### 4. Update and release `execution/evm` module
149+
143150
```bash
144151
cd execution/evm
145152

@@ -161,6 +168,7 @@ go list -m github.com/rollkit/rollkit/execution/evm@v<version>
161168
After core and main rollkit are available, update and release sequencers:
162169

163170
#### 5. Update and release `sequencers/*`
171+
164172
```bash
165173
# Update dependencies
166174
go get github.com/rollkit/rollkit/core@v<version>
@@ -177,6 +185,7 @@ go list -m github.com/rollkit/rollkit/sequencers/based@v<version>
177185
```
178186

179187
#### 6. Update and release `sequencers/single`
188+
180189
```bash
181190
cd sequencers/single
182191

@@ -198,6 +207,7 @@ go list -m github.com/rollkit/rollkit/sequencers/single@v<version>
198207
After all dependencies are available, update and release applications:
199208

200209
#### 7. Update and release `apps/evm/based`
210+
201211
```bash
202212
cd apps/evm/based
203213

@@ -218,6 +228,7 @@ go list -m github.com/rollkit/rollkit/apps/evm/based@v<version>
218228
```
219229

220230
#### 8. Update and release `apps/evm/single`
231+
221232
```bash
222233
cd apps/evm/single
223234

apps/evm/single/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ This directory contains the implementation of a single EVM sequencer using Rollk
1818
```bash
1919
go build -o evm-single .
2020
```
21-
21+
2222
3. Initialize the sequencer:
2323

2424
```bash
@@ -70,7 +70,7 @@ The sequencer can be configured using various command-line flags. The most impor
7070
7171
4. Identify the sequencer node's P2P address from its logs. It will look similar to:
7272

73-
```
73+
```sh
7474
1:55PM INF listening on address=/ip4/127.0.0.1/tcp/7676/p2p/12D3KooWJ1J5W7vpHuyktcvc71iuduRgb9pguY9wKMNVVPwweWPk module=main
7575
```
7676

block/retriever.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func (m *Manager) processNextDAHeaderAndData(ctx context.Context) error {
7474
if fetchErr == nil {
7575
// Record successful DA retrieval
7676
m.recordDAMetrics("retrieval", true)
77-
77+
7878
if blobsResp.Code == coreda.StatusNotFound {
7979
m.logger.Debug("no blob data found", "daHeight", daHeight, "reason", blobsResp.Message)
8080
return nil
@@ -214,10 +214,10 @@ func (m *Manager) fetchBlobs(ctx context.Context, daHeight uint64) (coreda.Resul
214214
var err error
215215
ctx, cancel := context.WithTimeout(ctx, dAefetcherTimeout)
216216
defer cancel()
217-
217+
218218
// Record DA retrieval attempt
219219
m.recordDAMetrics("retrieval", false)
220-
220+
221221
// TODO: we should maintain the original error instead of creating a new one as we lose context by creating a new error.
222222
blobsRes := types.RetrieveWithHelpers(ctx, m.da, m.logger, daHeight, []byte(m.genesis.ChainID))
223223
switch blobsRes.Code {

block/submitter.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,18 +113,18 @@ func submitToDA[T any](
113113
remLen = len(remaining)
114114

115115
submitctx, submitCtxCancel := context.WithTimeout(ctx, 60*time.Second)
116-
116+
117117
// Record DA submission attempt
118118
m.recordDAMetrics("submission", false)
119-
119+
120120
res := types.SubmitWithHelpers(submitctx, m.da, m.logger, currMarshaled, gasPrice, nil)
121121
submitCtxCancel()
122122

123123
switch res.Code {
124124
case coreda.StatusSuccess:
125125
// Record successful DA submission
126126
m.recordDAMetrics("submission", true)
127-
127+
128128
m.logger.Info(fmt.Sprintf("successfully submitted %s to DA layer", itemType), "gasPrice", gasPrice, "count", res.SubmittedCount)
129129
if res.SubmittedCount == uint64(remLen) {
130130
submittedAll = true

block/sync.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ func (m *Manager) SyncLoop(ctx context.Context, errCh chan<- error) {
1717
defer daTicker.Stop()
1818
blockTicker := time.NewTicker(m.config.Node.BlockTime.Duration)
1919
defer blockTicker.Stop()
20-
20+
2121
// Create ticker for periodic metrics updates
2222
metricsTicker := time.NewTicker(30 * time.Second)
2323
defer metricsTicker.Stop()
24-
24+
2525
for {
2626
select {
2727
case <-daTicker.C:
@@ -50,7 +50,7 @@ func (m *Manager) SyncLoop(ctx context.Context, errCh chan<- error) {
5050
continue
5151
}
5252
m.headerCache.SetItem(headerHeight, header)
53-
53+
5454
// Record header synced metric
5555
m.recordSyncMetrics("header_synced")
5656

@@ -95,7 +95,7 @@ func (m *Manager) SyncLoop(ctx context.Context, errCh chan<- error) {
9595
continue
9696
}
9797
m.dataCache.SetItem(dataHeight, data)
98-
98+
9999
// Record data synced metric
100100
m.recordSyncMetrics("data_synced")
101101

@@ -167,7 +167,7 @@ func (m *Manager) trySyncNextBlock(ctx context.Context, daHeight uint64) error {
167167
if err = m.store.SetHeight(ctx, hHeight); err != nil {
168168
return err
169169
}
170-
170+
171171
// Record sync metrics
172172
m.recordSyncMetrics("block_applied")
173173

client/crates/rollkit-client/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
151151

152152
// Service clients can be used concurrently
153153
let mut handles = vec![];
154-
154+
155155
for height in 0..10 {
156156
let store_clone = store.clone();
157157
let handle = task::spawn(async move {

0 commit comments

Comments
 (0)