save only on exit

Author: julienrbrt

block/internal/cache/generic_cache.go

@@ -131,15 +131,6 @@ func (c *Cache[T]) setDAIncluded(hash string, daHeight uint64, blockHeight uint6
 	c.daIncluded.Add(hash, daHeight)
 	c.hashByHeight.Add(blockHeight, hash)
 
-	// Persist to store if configured
-	if c.store != nil {
-		key := c.storeKeyPrefix + hash
-		value := make([]byte, 16) // 8 bytes for daHeight + 8 bytes for blockHeight
-		binary.LittleEndian.PutUint64(value[0:8], daHeight)
-		binary.LittleEndian.PutUint64(value[8:16], blockHeight)
-		_ = c.store.SetMetadata(context.Background(), key, value)
-	}
-
 	// Update max DA height if necessary
 	c.setMaxDAHeight(daHeight)
 }

block/internal/cache/generic_cache_test.go

@@ -61,11 +61,14 @@ func TestCache_MaxDAHeight_WithStore(t *testing.T) {
 		t.Errorf("after setDAIncluded: daHeight = %d, want 200", got)
 	}
 
+	err := c1.SaveToStore(ctx)
+	require.NoError(t, err)
+
 	// Create new cache and restore from store
 	c2 := NewCache[testItem](st, "test/da-included/")
 
 	// Restore with the known hashes
-	err := c2.RestoreFromStore(ctx, []string{"hash1", "hash2", "hash3"})
+	err = c2.RestoreFromStore(ctx, []string{"hash1", "hash2", "hash3"})
 	require.NoError(t, err)
 
 	if got := c2.daHeight(); got != 200 {
@@ -93,14 +96,17 @@ func TestCache_WithStorePersistence(t *testing.T) {
 
 	c1 := NewCache[testItem](st, "test/")
 
-	// Set DA inclusion - this should persist to store immediately
+	// Set DA inclusion
 	c1.setDAIncluded("hash1", 100, 1)
 	c1.setDAIncluded("hash2", 200, 2)
 
+	err := c1.SaveToStore(ctx)
+	require.NoError(t, err)
+
 	// Create new cache with same store and restore
 	c2 := NewCache[testItem](st, "test/")
 
-	err := c2.RestoreFromStore(ctx, []string{"hash1", "hash2", "hash3"})
+	err = c2.RestoreFromStore(ctx, []string{"hash1", "hash2", "hash3"})
 	require.NoError(t, err)
 
 	// hash1 and hash2 should be restored, hash3 should not exist

block/internal/cache/manager_test.go

@@ -431,6 +431,9 @@ func TestManager_DAInclusionPersistence(t *testing.T) {
 	// Verify DA height is tracked
 	assert.Equal(t, uint64(101), m1.DaHeight())
 
+	err = m1.SaveToStore()
+	require.NoError(t, err)
+
 	// Create new manager - DA inclusion should be restored
 	m2, err := NewManager(cfg, st, zerolog.Nop())
 	require.NoError(t, err)