Skip to content

Commit d2512dd

Browse files
committed
Review feedback
1 parent 3b74695 commit d2512dd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/e2e/evm_contract_bench_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func BenchmarkEvmContractRoundtrip(b *testing.B) {
4848

4949
// Start an in-process OTLP/HTTP receiver to collect traces from ev-node.
5050
collector := newOTLPCollector(b)
51-
defer collector.close()
51+
defer collector.close() // nolint: errcheck // test only
5252

5353
// Start sequencer with tracing enabled, exporting to our in-process collector.
5454
client, _, cleanup := setupTestSequencer(b, sequencerHome,
@@ -157,10 +157,10 @@ func (c *otlpCollector) endpoint() string {
157157
return "http://" + c.addr
158158
}
159159

160-
func (c *otlpCollector) close() {
160+
func (c *otlpCollector) close() error {
161161
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
162162
defer cancel()
163-
_ = c.server.Shutdown(ctx)
163+
return c.server.Shutdown(ctx)
164164
}
165165

166166
func (c *otlpCollector) handleTraces(w http.ResponseWriter, r *http.Request) {

0 commit comments

Comments
 (0)