diff --git a/docs/learn/config.md b/docs/learn/config.md index 18dd0df48e..3f735e5dfe 100644 --- a/docs/learn/config.md +++ b/docs/learn/config.md @@ -817,8 +817,8 @@ signer: ``` **Command-line Flag:** -`--rollkit.signer.type ` -_Example:_ `--rollkit.signer.type grpc` +`--rollkit.signer.signer_type ` +_Example:_ `--rollkit.signer.signer_type grpc` _Default:_ (Depends on application, often "file" or none if not an aggregator) _Constant:_ `FlagSignerType` @@ -836,8 +836,8 @@ signer: ``` **Command-line Flag:** -`--rollkit.signer.path ` -_Example:_ `--rollkit.signer.path ./keys/mykey.pem` +`--rollkit.signer.signer_path ` +_Example:_ `--rollkit.signer.signer_path ./keys/mykey.pem` _Default:_ (Depends on application) _Constant:_ `FlagSignerPath` diff --git a/pkg/config/config.go b/pkg/config/config.go index 35451e9a1e..6721f12174 100644 --- a/pkg/config/config.go +++ b/pkg/config/config.go @@ -105,9 +105,9 @@ const ( // Signer configuration flags // FlagSignerType is a flag for specifying the signer type - FlagSignerType = FlagPrefixEvnode + "signer.type" + FlagSignerType = FlagPrefixEvnode + "signer.signer_type" // FlagSignerPath is a flag for specifying the signer path - FlagSignerPath = FlagPrefixEvnode + "signer.path" + FlagSignerPath = FlagPrefixEvnode + "signer.signer_path" // FlagSignerPassphrase is a flag for specifying the signer passphrase //nolint:gosec diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go index f1f13f5894..3fc90cb9c6 100644 --- a/pkg/config/config_test.go +++ b/pkg/config/config_test.go @@ -174,6 +174,7 @@ signer: "--rollkit.da.address", "http://flag-da:26657", "--rollkit.node.light", "true", // This is not in YAML, should be set from flag "--rollkit.rpc.address", "127.0.0.1:7332", + "--evnode.signer.signer_path", "/path/to/signer", } cmd.SetArgs(flagArgs) err = cmd.ParseFlags(flagArgs) @@ -199,8 +200,8 @@ signer: assert.Equal(t, DefaultConfig.DA.BlockTime.Duration, config.DA.BlockTime.Duration, "DABlockTime should remain as default") // 5. Signer values should be set from flags - assert.Equal(t, "file", config.Signer.SignerType, "SignerType should be set from flag") - assert.Equal(t, "something/config", config.Signer.SignerPath, "SignerPath should be set from flag") + assert.Equal(t, "file", config.Signer.SignerType, "SignerType should be gotten from config") + assert.Equal(t, "/path/to/signer", config.Signer.SignerPath, "SignerPath should be set from flag") assert.Equal(t, "127.0.0.1:7332", config.RPC.Address, "RPCAddress should be set from flag") }