documentation of perl::module's use_package parameter conflicts with implementation

[sbakker]

The documentation for perl::module says that the default value for use_package is true, while in fact it is false.

Also, would you consider doing:

define perl::module (
    $use_package = hiera('perl::module::use_package', false),
    ....

That would allow users to specify the default in Hiera (Puppet seems to use Hiera for class parameters automagically, but not defined types).

Cheers,
Steven

[alvagante]

For the documentation fix PR is welcomed.
For the define, I'd avoid a hiera call like that in a define param (what would be the value for different modules?). If you want to manage that via hiera you should place the define inside a custom wrapper class that exposes the parameers you want to manage via Hiera.

[sbakker]

Hi, took a while for me to get around to this. I just generated a PR with that fix, plus another one to correctly determine the Debian package name to avoid bogus notifications on subsequent puppet runs.