Skip to content

check_receipts_multiple should return PushReceipt objects #65

@dzanotelli

Description

@dzanotelli

check_receipts_multiple (and its many callers) should return PushReceipt objects, instead it seems to return PushTicket objects.
Fortunately they are almost identical, almost same attributes etc. (if it quacks like a duck ...), yet to be fixed.

PushTicket(push_message=PushMessage(),

                PushTicket(push_message=PushMessage(),
                           status=val.get('status', PushTicket.ERROR_STATUS),
                           message=val.get('message', ''),
                           details=val.get('details', None),
                           id=r_id))

should become

                PushReceipt(
                           status=val.get('status', PushTicket.ERROR_STATUS),
                           message=val.get('message', ''),
                           details=val.get('details', None),
                           id=r_id))

removing the push_message part which is nonsense (and not a receipt prop).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions