example(goshippo): added new connector for goshippo connector #436

fivetran-sushmitha · 2025-10-31T18:12:00Z

Jira ticket

Closes <ADD TICKET LINK HERE, EACH PR MUST BE LINKED TO A JIRA TICKET>

Description of Change

<MENTION A SHORT DESCRIPTION OF YOUR CHANGES HERE>

Testing

<MENTION ABOUT YOUR TESTING DETAILS HERE, ATTACH SCREENSHOTS IF NEEDED (WITHOUT PII)>

Checklist

Some tips and links to help validate your PR:

Tested the connector with fivetran debug command.
Added/Updated example specific README.md file, refer here for template.
Followed Python Coding Standards, refer here

github-actions · 2025-10-31T18:12:25Z

🧹 Python Code Quality Check

✅ No issues found in Python Files.

🔍 See how this check works

This comment is auto-updated with every commit.

Copilot

Pull Request Overview

This PR introduces a new connector for Goshippo, a shipping API platform. The connector syncs shipment data from the Goshippo API to Fivetran destinations using incremental sync based on timestamp filtering.

Key changes:

Implements a complete Goshippo connector with pagination, retry logic, and incremental sync support
Defines schema for four related tables: shipments, shipment_rates, shipment_parcels, and shipment_messages
Uses client-side filtering for incremental sync with checkpointing at regular intervals

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
connectors/goshippo/connector.py	New connector implementation with complete data fetching, processing, and error handling logic
connectors/goshippo/configuration.json	Configuration file with API token placeholder

connectors/goshippo/connector.py

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

connectors/goshippo/connector.py

fivetran-sahilkhirwal

Please address the existing copilot comments
Also, link the example to the main README :)

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

connectors/goshippo/connector.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Updated the README to improve clarity on API token retrieval and error handling. Enhanced table descriptions for better understanding.

Clarified the description of tables created by the connector.

fivetran-dejantucakov

@fivetran-sushmitha Docs approved with changes

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.

connectors/goshippo/connector.py

connectors/goshippo/README.md

connectors/goshippo/connector.py

connectors/goshippo/README.md

connectors/goshippo/connector.py

connectors/goshippo/README.md

fivetran-sahilkhirwal

Can you please address the copilot comments

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

connectors/solace/connector.py

connectors/goshippo/connector.py

connectors/solace/connector.py

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

fivetran-dejantucakov

@fivetran-sushmitha Re-approved

example(goshippo): added new connector for goshippo connector

e5c53e6

Copilot AI review requested due to automatic review settings October 31, 2025 18:12

fivetran-sushmitha requested a review from a team as a code owner October 31, 2025 18:12

github-actions bot added the size/XL PR size: extra large label Oct 31, 2025

Copilot AI reviewed Oct 31, 2025

View reviewed changes

fivetran-sushmitha added the hackathon For all the PRs related to the internal Fivetran 2025 Connector SDK Hackathon. label Oct 31, 2025

fivetran-sahilkhirwal requested review from Copilot, fivetran-pranavtotala and fivetran-sahilkhirwal October 31, 2025 18:45

Copilot AI reviewed Oct 31, 2025

View reviewed changes

connectors/goshippo/connector.py Outdated Show resolved Hide resolved

connectors/goshippo/connector.py Show resolved Hide resolved

connectors/goshippo/connector.py Outdated Show resolved Hide resolved

fivetran-sahilkhirwal requested changes Nov 6, 2025

View reviewed changes

fivetran-sahilkhirwal added the top-priority A top priority PR for review label Nov 10, 2025

fivetran-sahilkhirwal assigned fivetran-sushmitha Nov 10, 2025

Address review comments

752a000

fivetran-sushmitha requested a review from a team as a code owner November 20, 2025 14:17

fivetran-sushmitha requested review from Copilot and fivetran-sahilkhirwal November 20, 2025 14:19

Copilot started reviewing on behalf of fivetran-sushmitha November 20, 2025 14:24 View session

Copilot finished reviewing on behalf of fivetran-sushmitha November 20, 2025 14:25

Copilot AI reviewed Nov 20, 2025

View reviewed changes

connectors/goshippo/connector.py Show resolved Hide resolved

connectors/goshippo/connector.py Outdated Show resolved Hide resolved

connectors/goshippo/connector.py Outdated Show resolved Hide resolved

connectors/goshippo/connector.py Outdated Show resolved Hide resolved

fivetran-sushmitha and others added 2 commits November 20, 2025 19:58

Update connectors/goshippo/connector.py

d2729bc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update connectors/goshippo/connector.py

421ce55

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fivetran-dejantucakov self-requested a review November 20, 2025 15:28

fivetran-dejantucakov self-assigned this Nov 20, 2025

fivetran-dejantucakov added 2 commits November 20, 2025 16:36

Refine README for API token and error handling

b1cd377

Updated the README to improve clarity on API token retrieval and error handling. Enhanced table descriptions for better understanding.

Update README to improve clarity on table creation

f27e203

Clarified the description of tables created by the connector.

fivetran-dejantucakov previously approved these changes Nov 20, 2025

View reviewed changes

fivetran-sushmitha added 2 commits November 20, 2025 21:19

Address review comments

28d771c

Address review comments

45ffbb9

fivetran-sushmitha dismissed fivetran-dejantucakov’s stale review via 45ffbb9 November 20, 2025 15:52

fivetran-sahilkhirwal requested a review from Copilot November 20, 2025 18:17

Copilot started reviewing on behalf of fivetran-sahilkhirwal November 20, 2025 18:18 View session

Copilot finished reviewing on behalf of fivetran-sahilkhirwal November 20, 2025 18:20

Copilot AI reviewed Nov 20, 2025

View reviewed changes

fivetran-sahilkhirwal reviewed Nov 20, 2025

View reviewed changes

fivetran-sushmitha and others added 5 commits November 24, 2025 19:24

Update connectors/goshippo/connector.py

fb309e9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update connectors/goshippo/connector.py

c8934ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update connectors/goshippo/connector.py

5061dc2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update connectors/goshippo/connector.py

c734c4d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update connectors/goshippo/README.md

e6fd01f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fivetran-sushmitha requested a review from fivetran-sahilkhirwal November 24, 2025 13:55

fixed few issues

ff25dce

fivetran-sahilkhirwal requested a review from Copilot November 25, 2025 05:58

Copilot started reviewing on behalf of fivetran-sahilkhirwal November 25, 2025 05:58 View session

Copilot finished reviewing on behalf of fivetran-sahilkhirwal November 25, 2025 06:02

Copilot AI reviewed Nov 25, 2025

View reviewed changes

connectors/solace/connector.py Outdated Show resolved Hide resolved

connectors/goshippo/connector.py Show resolved Hide resolved

fivetran-sahilkhirwal reviewed Nov 25, 2025

View reviewed changes

connectors/solace/connector.py Show resolved Hide resolved

reverted unnecessary change

bdd79e5

fivetran-sushmitha requested a review from fivetran-sahilkhirwal November 25, 2025 07:32

fivetran-sahilkhirwal requested a review from Copilot November 25, 2025 08:01

Copilot started reviewing on behalf of fivetran-sahilkhirwal November 25, 2025 08:02 View session

Copilot finished reviewing on behalf of fivetran-sahilkhirwal November 25, 2025 08:03

Copilot AI reviewed Nov 25, 2025

View reviewed changes

fivetran-sahilkhirwal approved these changes Nov 25, 2025

View reviewed changes

fivetran-dejantucakov approved these changes Nov 25, 2025

View reviewed changes

fivetran-sushmitha merged commit ac7edd9 into main Nov 25, 2025
9 checks passed

fivetran-sushmitha deleted the goshippo branch November 25, 2025 08:56

example(goshippo): added new connector for goshippo connector #436

example(goshippo): added new connector for goshippo connector #436

Uh oh!

Conversation

fivetran-sushmitha commented Oct 31, 2025

Jira ticket

Description of Change

Testing

Checklist

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧹 Python Code Quality Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-sahilkhirwal left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-dejantucakov left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-sahilkhirwal left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

fivetran-dejantucakov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

github-actions bot commented Oct 31, 2025 •

edited

Loading