[2.x: Tags & Mention] If a post is mentioned from different discussion, clicking the mention notification will jump to the original post

[zDaleZ]

Current Behavior

If a post is mentioned from different discussion, clicking the mention notification will jump to the original post.

e.g. If I mention /d/2-test-reply/1 at /d/3-test-reply-2/2, then clicking the mention notification will navigate to /d/2-test-reply/1, instead of /d/3-test-reply-2/2.

Steps to Reproduce

See above

Expected Behavior

We should go to the post that mentioned the original post, instead of the original post itself.

If the current behavior is expected, could we consider changing it? It does jump to the target post when it's in the same discussion of the original post, so unify the behaviors of different cases really helps.

Screenshots

No response

Environment

• Website URL: https://nightly.flarum.site

Output of php flarum info

(nightly.flarum.site)

Possible Solution

No response

Additional Context

No response

[imorland]

I just tested this, but I cannot reproduce. Is this still an issue for you?

[zDaleZ]

I remember it requires more conditions to trigger the bug...The two discussions must have different tags (that's why I mentioned tags in issue title). Sorry for not explaining clearly.

[zDaleZ]

@imorland still happens

The reason why I don't test it on nightly.flarum.site is just because it's down right now. But I believe it's not related to any DB.

Just let the two discussions have different tag (or combinations), the problem can occur.
The two discussions can have the same primary tag, but with different subtag, too.