Skip to content

Conversation

@noot
Copy link
Contributor

@noot noot commented Dec 4, 2025

📝 Summary

use rollup-boost-types crate for necessary types instead of importing all of rollup-boost. see flashbots/rollup-boost#450

💡 Motivation and Context

don't need to pull and build all of rollup-boost for a few types anymore :D

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copilot AI review requested due to automatic review settings December 4, 2025 23:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dependency from the full rollup-boost crate to the lighter rollup-boost-types crate, which contains only the necessary type definitions. This reduces build overhead by avoiding compilation of the entire rollup-boost codebase when only type definitions are needed.

Key changes:

  • Replaced rollup-boost dependency with rollup-boost-types using a specific git revision
  • Updated import paths to reference the new crate structure with module-qualified paths

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Updated workspace dependency from rollup-boost to rollup-boost-types with git revision
crates/op-rbuilder/Cargo.toml Replaced rollup-boost dependency with rollup-boost-types
crates/op-rbuilder/src/tests/framework/instance.rs Updated import path for FlashblocksPayloadV1 to use rollup-boost-types
crates/op-rbuilder/src/tests/framework/driver.rs Updated import path for OpExecutionPayloadEnvelope to use rollup-boost-types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 4, 2025 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avalonche
Copy link
Collaborator

The dependency can be removed due to #328, can you import from op-alloy instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants