-
Notifications
You must be signed in to change notification settings - Fork 41
deps: use rollup-boost-types instead of rollup-boost #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the dependency from the full rollup-boost crate to the lighter rollup-boost-types crate, which contains only the necessary type definitions. This reduces build overhead by avoiding compilation of the entire rollup-boost codebase when only type definitions are needed.
Key changes:
- Replaced
rollup-boostdependency withrollup-boost-typesusing a specific git revision - Updated import paths to reference the new crate structure with module-qualified paths
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updated workspace dependency from rollup-boost to rollup-boost-types with git revision |
| crates/op-rbuilder/Cargo.toml | Replaced rollup-boost dependency with rollup-boost-types |
| crates/op-rbuilder/src/tests/framework/instance.rs | Updated import path for FlashblocksPayloadV1 to use rollup-boost-types |
| crates/op-rbuilder/src/tests/framework/driver.rs | Updated import path for OpExecutionPayloadEnvelope to use rollup-boost-types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The dependency can be removed due to #328, can you import from op-alloy instead? |
📝 Summary
use rollup-boost-types crate for necessary types instead of importing all of rollup-boost. see flashbots/rollup-boost#450
💡 Motivation and Context
don't need to pull and build all of rollup-boost for a few types anymore :D
✅ I have completed the following steps:
make lintmake test