-
Notifications
You must be signed in to change notification settings - Fork 1.9k
out_azure_kusto: Add changes to defer close old resource handles in subsequent cycles #11418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ag-ramachandran
wants to merge
4
commits into
fluent:master
Choose a base branch
from
ag-ramachandran:bugfix/FixOldIngestResourceLeaks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f270724
out_azure_kusto: Defer close old resource handles in next cycle
ag-ramachandran c2a75c8
out_azure_kusto: Add comments & logs for cleanup
ag-ramachandran 437bbe1
Merge branch 'fluent:master' into bugfix/FixOldIngestResourceLeaks
ag-ramachandran 10c9dfc
Merge branch 'fluent:master' into bugfix/FixOldIngestResourceLeaks
ag-ramachandran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 209
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 124
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 134
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 143
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 231
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 166
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 829
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 551
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 291
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 901
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 5289
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 107
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 4998
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 11345
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 1092
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 232
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 270
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 1335
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 5997
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 2181
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 1259
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 95
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 4832
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 5853
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 2030
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 43
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 1441
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 4467
🏁 Script executed:
Repository: fluent/fluent-bit
Length of output: 1367
Mutex protection is insufficient for safe resource rotation during ingest operations.
The
resources_mutexis released after rotation (line 668 inazure_kusto_load_ingestion_resources), but ingest operations access the resources without reacquiring the lock. Inazure_kusto_create_blob()(line 157) andazure_kusto_enqueue_ingestion()(line 425), calls toflb_upstream_ha_node_get(ctx->resources->blob_ha)andflb_upstream_ha_node_get(ctx->resources->queue_ha)happen without holdingresources_mutex. Worker threads can hold pointers to these resources across multiple function calls after the initial refresh, so a concurrent rotation can move the current resources to old and destroy them while the worker thread is still using them on the next refresh cycle.🤖 Prompt for AI Agents