-
Notifications
You must be signed in to change notification settings - Fork 800
Description
Motivation: Why do you think this is important?
The flytekit remote client relies on gRPC for communication with the control plane (FlyteAdmin). However, our experience has revealed numerous issues within Python gRPC, leading to test failures. Additionally, users frequently encounter challenges when working with specific versions of gRPC.
In order to eliminate the gRPC Python dependency from flytekit, our goal is to develop a Rust crate to serve as a replacement for the flytekit remote client. To achieve this, we plan to utilize Pyo3 to generate a Python binding, allowing flytekit to seamlessly integrate and utilize the new implementation.
Goal: What should the final outcome look like, ideally?
flyteorg/flytekit#2377 is a POC of a rust remote client that allows you to get/create tasks without Python grpc
Add a flag (enable_rust) to the FlyteRemote class. When this flag is true, FlyteRemote will use the rust implementation.
remote_rs = FlyteRemote(Config.auto(), default_project=PROJECT, default_domain=DOMAIN, enable_rust=True)
flyte_task = remote_rs.register_task(
entity=my_test_task,
serialization_settings=SerializationSettings(
image_config=ImageConfig.auto(img_name="flyte-cr.io/image-name:tag")
),
version=VERSION_ID,
)
flyte_task = remote_rs.fetch_task(name=TASK_NAME, version=VERSION_ID)Follow up Issues
- Add a test for the rust remote client
- Add a GA workflow to run rust remote client without installing Python grpc
- Add a GA workflow to make sure the output of the Rust remote and Python remote are the same
- Pass credentials from python to rust
- OAuth flow in the rust implementation
Describe alternatives you've considered
Use existing flytekit remote client
Propose: Link/Inline OR Additional context
- Fix: Fix GCP Identity Aware Proxy integration errors occurring with grpcio>1.56.0 flytekit#2034
- Skip version 1.45.0 of grpcio and grpcio-status flytekit#913
- bug(python): Regression in
grpcio>=1.59.0related to grpc thread pool hanging ingrpc_google_default_credentials_creategrpc/grpc#36265
Are you sure this issue hasn't been raised already?
- Yes
Have you read the Code of Conduct?
- Yes