From fb79765647eb8ead39c3c2369ba9abcc6b53d119 Mon Sep 17 00:00:00 2001 From: byhsu Date: Sun, 28 May 2023 12:27:16 -0700 Subject: [PATCH] Generate config_flags for http proxy Signed-off-by: byhsu --- clients/go/admin/config_flags.go | 1 + clients/go/admin/config_flags_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+) diff --git a/clients/go/admin/config_flags.go b/clients/go/admin/config_flags.go index 53a6a4421..0472413b5 100755 --- a/clients/go/admin/config_flags.go +++ b/clients/go/admin/config_flags.go @@ -76,5 +76,6 @@ func (cfg Config) GetPFlagSet(prefix string) *pflag.FlagSet { cmdFlags.String(fmt.Sprintf("%v%v", prefix, "deviceFlowConfig.pollInterval"), defaultConfig.DeviceFlowConfig.PollInterval.String(), "amount of time the device flow would poll the token endpoint if auth server doesn't return a polling interval. Okta and google IDP do return an interval'") cmdFlags.StringSlice(fmt.Sprintf("%v%v", prefix, "command"), defaultConfig.Command, "Command for external authentication token generation") cmdFlags.String(fmt.Sprintf("%v%v", prefix, "defaultServiceConfig"), defaultConfig.DefaultServiceConfig, "") + cmdFlags.String(fmt.Sprintf("%v%v", prefix, "httpProxyURL"), defaultConfig.HTTPProxyURL.String(), "OPTIONAL: HTTP Proxy to be used for OAuth requests.") return cmdFlags } diff --git a/clients/go/admin/config_flags_test.go b/clients/go/admin/config_flags_test.go index bdcec55f6..1fb1e2a21 100755 --- a/clients/go/admin/config_flags_test.go +++ b/clients/go/admin/config_flags_test.go @@ -463,4 +463,18 @@ func TestConfig_SetFlags(t *testing.T) { } }) }) + t.Run("Test_httpProxyURL", func(t *testing.T) { + + t.Run("Override", func(t *testing.T) { + testValue := defaultConfig.HTTPProxyURL.String() + + cmdFlags.Set("httpProxyURL", testValue) + if vString, err := cmdFlags.GetString("httpProxyURL"); err == nil { + testDecodeJson_Config(t, fmt.Sprintf("%v", vString), &actual.HTTPProxyURL) + + } else { + assert.FailNow(t, err.Error()) + } + }) + }) }