Skip to content

Escape values provided by user #3

@foglcz

Description

@foglcz

As in #2 , the values coming either from user and/or LDAP itself, can contain unescaped sequences.

Escape values properly, ie. using this -> http://php.net/manual/en/function.ldap-escape.php

For example, a comma is a wrong character, that when unescaped, throws an exception during search. Comma could be there, because you can have a group name:

HSBC (Pvt.) Ltd., Asia
(^ the character needing escaping is a comma, which will get escaped by LDAP. NEEDS TESTING!!)

Backend tests:

  • Groupname with a backslash
  • Groupname with a comma
  • Groupname with backslash, that is member of a group of the user
  • Groupname with comma, that is member of a group of the user

"Frontend" tests - supply values to authenticator:

  • Comma in a username
  • Dot in a username
  • Backslash in a username

Metadata

Metadata

Assignees

Labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions