Skip to content
This repository was archived by the owner on Jun 10, 2024. It is now read-only.
This repository was archived by the owner on Jun 10, 2024. It is now read-only.

Allow custom symlinks to be defined for minification #1

@real34

Description

@real34

We encountered issues with the extension with a theme from the .modman directory. Relative urls were not rewritten properly because of the filepath set to a realpath.

Thus the call to \Minify_CSS::minify was made with a currentDir looking like /absolute/path/.modman/my-theme/skin/frontend/theme/default/css and a docRoot like /absolute/path/htdocs.
Assets url were modified incorrectly and it led to urls like: n/my-theme/skin/frontend/theme/default/images/xx.png.

The best fix we found was to add an entry to the $min_symlinks array in m.php like so:

$min_symlinks["//skin/frontend"] = realpath($rootdir . "../../../.modman/my-theme/skin/frontend");

It worked pretty well, however Speedster does not allow to set it properly. Our hack was to add a sed command in the theme modman file, but it is error prone since it is dependent on the line number.

Would it be possible to add a config in the admin or a custom file to be loaded so $min_symlinks could be customized?
WOuld you rather suggest a different directory organization?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions