Skip to content

task: Add title length constraint for recipe revisions #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GV14982 merged 1 commit into from
Aug 20, 2025
Merged

task: Add title length constraint for recipe revisions #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions api/services/recipe/recipe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ const (
DEFAULT_LIST_RECIPE_SORT_FIELD = "publish_date"
)

func validateTitle(title string) error {
if len(title) < 3 {
return fmt.Errorf("title must be at least 3 characters long")
}
if len(title) > 150 {
return fmt.Errorf("title must be no more than 150 characters long")
}
return nil
}

type RecipeService interface {
GetRecipeByID(ctx context.Context, id uuid.UUID) (*model.Recipe, error)
GetRecipeBySlug(ctx context.Context, slug string, displayName string) (*model.Recipe, error)
Expand Down Expand Up @@ -142,6 +152,10 @@ func (r recipeService) AddRecipeRevision(ctx context.Context, input model.AddRev
return nil, nil
}

if err := validateTitle(input.Revision.Title); err != nil {
return nil, err
}

tx, err := r.conn.Begin(ctx)
if err != nil {
return nil, err
Expand Down Expand Up @@ -248,6 +262,10 @@ func (r recipeService) CreateRecipe(ctx context.Context, input model.CreateRecip
return nil, nil
}

if err := validateTitle(input.Revision.Title); err != nil {
return nil, err
}

user, _ := r.authService.GetUserSessionFromCtx(ctx)

tx, err := r.conn.Begin(ctx)
Expand Down
2 changes: 2 additions & 0 deletions db/migrations/20250812230844_add_title_length_constraint.down.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ALTER TABLE recipe_revisions
DROP CONSTRAINT title_length_check;
3 changes: 3 additions & 0 deletions db/migrations/20250812230844_add_title_length_constraint.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ALTER TABLE recipe_revisions
ADD CONSTRAINT title_length_check
CHECK (char_length(trim(title)) >= 3 AND char_length(trim(title)) <= 150);
Loading