Fix encoding for non-ascii char in kerberos authentication #2068
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2025
Contributor
Author
|
@anadrianmanrique any chance you could press the "i believe" button on this one? Especially in domains where you have non-ascii chars in entities like the DA by default, it must be painful not be able to use kerberos. |
Collaborator
|
I'm calling it the day right now, and be off the next 2 weeks. Summoning @gabrielg5 to take care of this one. Thanks |
Contributor
Author
|
If you need any info/help @gabrielg5 let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the hack.lu CTF this year and therefore a swedish AD environment it was reported that Kerberos authentication does not work with special chars (e.g.
öäü) that are present in some localized environments: Pennyw0rth/NetExec#963The problem is that kerberos uses
utf-8encoding for Kerberos Strings. However, as of now both minikerberos as well as impacket uselatin1as its encoding, resulting in failed authentication with users that contain special chars.See:
Before and after:
Fixed and used in NetExec:
