Keep resources of failed calls in trace

Author: ddoktorski

crates/cheatnet/src/runtime_extensions/call_to_blockifier_runtime_extension/execution/execution_utils.rs

@@ -10,7 +10,6 @@ use blockifier::execution::call_info::CallInfo;
 use blockifier::execution::entry_point::{CallEntryPoint, CallType, ExecutableCallEntryPoint};
 use blockifier::execution::errors::EntryPointExecutionError;
 use blockifier::execution::syscalls::vm_syscall_utils::SyscallUsageMap;
-use cairo_vm::vm::runners::cairo_runner::ExecutionResources;
 
 pub(crate) fn resolve_cheated_data_for_call(
     entry_point: &mut CallEntryPoint,
@@ -75,14 +74,8 @@ pub(crate) fn exit_error_call(
         CallType::Call => AddressOrClassHash::ContractAddress(entry_point.storage_address),
         CallType::Delegate => AddressOrClassHash::ClassHash(entry_point.class_hash),
     };
-    cheatnet_state.trace_data.update_and_exit_nested_call(
-        ExecutionResources::default(),
-        u64::default(),
-        SyscallUsageMap::default(),
-        SyscallUsageMap::default(),
-        CallResult::from_err(error, &identifier),
-        &[],
-        vec![],
-        vec![],
-    );
+    cheatnet_state
+        .trace_data
+        .update_call_result(CallResult::from_err(error, &identifier));
+    cheatnet_state.trace_data.exit_nested_call();
 }

crates/cheatnet/src/state.rs

@@ -588,6 +588,11 @@ impl TraceData {
         current_call.borrow_mut().vm_trace = Some(vm_trace);
     }
 
+    pub fn update_call_result(&mut self, result: CallResult) {
+        let current_call = self.current_call_stack.top();
+        current_call.borrow_mut().result = result;
+    }
+
     #[expect(clippy::too_many_arguments)]
     pub fn update_current_call(
         &mut self,
@@ -618,31 +623,6 @@ impl TraceData {
         current_call.events = events;
     }
 
-    #[expect(clippy::too_many_arguments)]
-    pub fn update_and_exit_nested_call(
-        &mut self,
-        execution_resources: ExecutionResources,
-        gas_consumed: u64,
-        used_syscalls_vm_resources: SyscallUsageMap,
-        used_syscalls_sierra_gas: SyscallUsageMap,
-        result: CallResult,
-        l2_to_l1_messages: &[OrderedL2ToL1Message],
-        signature: Vec<Felt>,
-        events: Vec<OrderedEvent>,
-    ) {
-        self.update_current_call(
-            execution_resources,
-            gas_consumed,
-            used_syscalls_vm_resources,
-            used_syscalls_sierra_gas,
-            result,
-            l2_to_l1_messages,
-            signature,
-            events,
-        );
-        self.exit_nested_call();
-    }
-
     pub fn exit_nested_call(&mut self) {
         self.current_call_stack.pop();
     }