Skip to content

Use a single source of thruth for the discovery of miscellaneous user paths #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twiggler wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use a single source of thruth for the discovery of miscellaneous user paths #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9643cc5
Use new api in dissect.target for home paths
twiggler Jun 25, 2025
752f464
Use target misc_homes functionality
twiggler Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 1 addition & 50 deletions acquire/acquire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,62 +102,13 @@
logging.raiseExceptions = False


def misc_windows_user_homes(target: Target) -> Iterator[fsutil.TargetPath]:
misc_dirs = {
("Windows/ServiceProfiles/LocalService", False),
("Windows/ServiceProfiles/NetworkService", False),
("Windows/System32/config/systemprofile", False),
("Users", True),
("Documents and Settings", True),
}

for fs in target.fs.path().iterdir():
if fs.name.lower() == "c:":
continue

for misc_dir, get_subdirs in misc_dirs:
misc_path = fs.joinpath(misc_dir)

if not misc_path.exists():
continue

if get_subdirs:
for entry in misc_path.iterdir():
if entry.is_dir():
yield entry
else:
yield misc_path


def misc_unix_user_homes(target: Target) -> Iterator[fsutil.TargetPath]:
user_dirs = ["root", "home/*"]

home_dirs = (target.fs.path("/").glob(path) for path in user_dirs)
yield from itertools.chain.from_iterable(home_dirs)


def misc_macos_user_homes(target: Target) -> Iterator[fsutil.TargetPath]:
yield from itertools.chain(target.fs.path("/Users/").glob("*"), misc_unix_user_homes(target))


MISC_MAPPING = {
"macos": misc_macos_user_homes,
"windows": misc_windows_user_homes,
}


def from_user_home(target: Target, path: str) -> Iterator[str]:
try:
for user_details in target.user_details.all_with_home():
yield user_details.home_path.joinpath(path).as_posix()
return (user_home.joinpath(path).as_posix() for user_home in target.user_details.all_home_paths)

Check warning on line 107 in acquire/acquire.py

View check run for this annotation

Codecov / codecov/patch

acquire/acquire.py#L107 

Added line #L107 was not covered by tests
except Exception as e:
log.warning("Error occurred when requesting all user homes")
log.debug("", exc_info=e)

misc_user_homes = MISC_MAPPING.get(target.os, misc_unix_user_homes)
for user_dir in misc_user_homes(target):
yield user_dir.joinpath(path).as_posix()


def iter_ntfs_filesystems(target: Target) -> Iterator[tuple[ntfs.NtfsFilesystem, str | None, str, str]]:
mount_lookup = defaultdict(list)
Expand Down
51 changes: 0 additions & 51 deletions tests/test_misc_users.py
View file
Open in desktop

This file was deleted.

Loading