Skip to content

fix: Stop autoconnect thread on quit #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elementbound merged 4 commits into from
Nov 8, 2025
Merged

fix: Stop autoconnect thread on quit #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08e9c82
Update network-simulator.gd
quicksnap Oct 31, 2025
c00b018
Merge pull request #1 from quicksnap/quicksnap-patch-1
quicksnap Oct 31, 2025
01efb9d
fxs
elementbound Nov 8, 2025
53bc615
bv
elementbound Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion addons/netfox.extras/network-simulator.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ var _enet_peer: ENetMultiplayerPeer = ENetMultiplayerPeer.new()

# UDP proxy
var _proxy_thread: Thread
var _proxy_loop_enabled := true
var _udp_proxy_server: PacketPeerUDP
var _udp_proxy_port: int
var _rng_packet_loss: RandomNumberGenerator = RandomNumberGenerator.new()
Expand Down Expand Up @@ -138,7 +139,7 @@ func _process_packets() -> void:
_process_server_to_client_queue(send_threshold)

func _process_loop():
while true:
while _proxy_loop_enabled:
_process_packets()
OS.delay_msec(1)

Expand Down Expand Up @@ -233,4 +234,5 @@ func _should_send_packet() -> bool:

func _exit_tree() -> void:
if _proxy_thread and _proxy_thread.is_started():
_proxy_loop_enabled = false
_proxy_thread.wait_to_finish()
2 changes: 1 addition & 1 deletion addons/netfox.extras/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox.extras"
description="Game-specific utilities for Netfox"
author="Tamas Galffy and contributors"
version="1.33.1"
version="1.33.2"
script="netfox-extras.gd"
2 changes: 1 addition & 1 deletion addons/netfox.internals/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox.internals"
description="Shared internals for netfox addons"
author="Tamas Galffy and contributors"
version="1.33.1"
version="1.33.2"
script="plugin.gd"
2 changes: 1 addition & 1 deletion addons/netfox.noray/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox.noray"
description="Bulletproof your connectivity with noray integration for netfox"
author="Tamas Galffy and contributors"
version="1.33.1"
version="1.33.2"
script="netfox-noray.gd"
2 changes: 1 addition & 1 deletion addons/netfox/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox"
description="Shared internals for netfox addons"
author="Tamas Galffy and contributors"
version="1.33.1"
version="1.33.2"
script="netfox.gd"
Loading