Skip to content

Inherit link styles for some themes #3073

@andeng1106

Description

@andeng1106

Describe the bug

  • Issue related to: https://www.notion.so/Rui-Raposo-094d33377f4e40679edd14ddc91d79f0
  • Issue in both editor and frontend
  • This issue applies to blocks such as:
    • Icon List block
    • Table of Contents block
    • Button block
  • Issue applies to themes such as but not limited to:
    • 2024 theme (Editor > Styles)
    • Blocksy (Customize > General > Entry Content > Links Type or see docs)
      • Note: Choose "Link Type 4" to see the difference
    • Kadence (Customize > Colors & Fonts > Colors > Content Links > Link Style or see docs)
      • Note: Choose "Background on Hover" to see the difference

To Reproduce
Steps to reproduce the behavior:

  1. Add new page (or skip steps 2-7 and use this test page instead)
  2. Add an Icon List block
  3. Add a link to one of the Icon List item
  4. Add a TOC block
  5. Add Heading blocks to fill the TOC block
  6. Add a Button block
  7. Change button style to "Link"
  8. Switch to any of the themes above
  9. Change Link styles in the theme customizer/editor
  10. See that the three blocks mentioned above is not inheriting the styles properly

Expected behavior

  • Button block > link style, Icon List with link, and TOC block contents should inherit link styles for some themes
  • A sample of how it's inherited properly for Stackable's Text block:
Screen.Recording.2024-02-22.at.4.23.06.PM.mov

Screenshots
2024 theme
Note: Seems to be working properly in 2024 theme but double check just in case

2024.theme.link.styles.mov

Blocksy Theme

Screen.Recording.2024-02-22.at.4.27.21.PM.mov

Kadence Theme

Screen.Recording.2024-02-22.at.4.25.23.PM.mov

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions