Update openReport.js to wait=true #1612
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably isn't a great solution, but I don't think this project is active anymore anyways. Mostly just opening this PR hoping that it will help somebody else who runs into the same issue as me.
This may not be advised, but I'm running backstop within a javascript file:
Any time a scenario compare failed, openReport.js would fail to open the HTML report. Turns out it was because an uncaught promise exception was causing my application to abort before the broswer window could open. I was able to resolve this by handling the return promise's error, which ensured the browser window would open:
Unfortunately, this is undocumented and unexpected. An alternative solution, as proposed by this PR, is to run the
open()command with config{ wait: true }, which prevents the error from being handled before the report opens.