Test issue for non-Intel architectures

[tillea]

Hi,
after upgrading the Debian package from version 2.1.8.1 to 2.1.9 the CI test we are running on different architectures failed for all non-Intel architectures which you can see in the debci check matrix. When you have a look into one of the test logs - for instance for arm64 you can find the problem is here:

 ----- FAILED[data]: test_least_squares.R<68--69>
  call| expect_true(abs(mean(data2$Y - f.predict)) < 0.01, info = "LS: checking if Gaussian absolute error within tolerance.")
  diff| Expected TRUE, got FALSE
  info| LS: checking if Gaussian absolute error within tolerance.
 ----- FAILED[data]: test_least_squares.R<70--71>
  call| expect_true(sd(data2$Y - f.predict) < sigma, info = "LS: checking if Gaussian squared error within tolerance.")
  diff| Expected TRUE, got FALSE
  info| LS: checking if Gaussian squared error within tolerance.
 Error: 2 out of 5 tests failed
 Execution halted

It might be that relaxing the test condition could help passing this test again but I have to less knowledge about the internals of this package.

Kind regards, Andreas.

[tillea]

Ping?

[tillea]

I wonder if the silence about this bug is connected to the advise to switch to gbm3. Unfortunately there are several packages in Debian (and thus CRAN) that depend on this version of gbm. I wonder whether the issue is visible also on CRAN test builds on non-Intel architectures.

[gregridgeway]

Silence mostly due to day jobs.

Can you try the following:

1. Install from github if you can't from CRAN, remotes::install_github("gbm-developers/gbm")
2. Run the test script inst/tinytest/test_least_squares.R
3. Let us know what the value of
   best.iter
   mean(data2$Y - f.predict)
   sd(data2$Y - f.predict)

[tillea]

Hi Greg, Am Thu, Apr 25, 2024 at 06:58:14AM -0700 schrieb Greg Ridgeway:

Silence mostly due to day jobs.

Fine. Will be true for me as well in the next couple of weeks. I was just elected as Debian Project Leader and all my packaging duties are left behind a bit. I try to do my best in debugging but it might last some time. l

Can you try the following: 1. Install from github if you can't from CRAN, remotes::install_github("gbm-developers/gbm") 2. Run the test script inst/tinytest/test_least_squares.R 3. Let us know what the value of best.iter mean(data2$Y - f.predict) sd(data2$Y - f.predict)

I put this somewhere on my todo list.

[mr-c]

R version 4.4.2 (2024-10-31) -- "Pile of Leaves"

# my notes on running the instructions on the Debian porter boxes
sessionid=$(schroot -b -c sid)
dd-schroot-cmd -c $sessionid apt-get -y update
dd-schroot-cmd -c $sessionid apt-get -y upgrade
dd-schroot-cmd -c $sessionid apt-get -y install r-base-dev r-cran-remotes
schroot -r -c $sessionid
R
dir.create(path = Sys.getenv("R_LIBS_USER"), showWarnings = FALSE, recursive = TRUE)
remotes::install_cran("tinytest", lib = Sys.getenv("R_LIBS_USER"))
remotes::install_github("gbm-developers/gbm", lib = Sys.getenv("R_LIBS_USER"))
library(gbm)
library(tinytest)
source("R/aarch64-unknown-linux-gnu-library/4.4/gbm/tinytest/test_least_squares.R")
best.iter
mean(data2$Y - f.predict)
sd(data2$Y - f.predict)
quit()
logout
schroot -e -c $sessionid
logout

arm64

> best.iter
[1] 1323
> mean(data2$Y - f.predict)
[1] -0.6870337
> sd(data2$Y - f.predict)
[1] 0.6467978

armel

best.iter
mean(data2$Y - f.predict)
sd(data2$Y - f.predict)
[1] 1323
[1] -0.6870337
[1] 0.6467978

armhf

> best.iter
mean(data2$Y - f.predict)
sd(data2$Y - f.predict)
[1] 1323
[1] -0.6870337
[1] 0.6467978

ppc64el

> best.iter
mean(data2$Y - f.predict)
sd(data2$Y - f.predict)
[1] 1323
[1] -0.6870337
[1] 0.6467978

riscv64

> source("R/riscv64-unknown-linux-gnu-library/4.4/gbm/tinytest/test_least_squares.R")
CV: 1 
munmap_chunk(): invalid pointer
Aborted

s390x

> best.iter
mean(data2$Y - f.predict)
sd(data2$Y - f.predict)
[1] 1323
[1] -0.6870337
[1] 0.6467978