Skip to content

Commit 4c30961

Browse files
committed
Eliminate unnecessary else branching
1 parent 5165caa commit 4c30961

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

src/PoFile.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public function addEntry(PoEntry $entry, bool $replace = true): bool
165165
{
166166
$key = $this->createKeyFromEntry($entry);
167167

168-
// some entires, such as obsolete entries, have no key
168+
// some entries, such as obsolete entries, have no key
169169
// for some uses, these are dead weight - need better strategy for that case
170170
if (empty($key)) {
171171
$this->unkeyedEntries[] = $entry;
@@ -174,10 +174,10 @@ public function addEntry(PoEntry $entry, bool $replace = true): bool
174174

175175
if (isset($this->entries[$key]) && !$replace) {
176176
return false;
177-
} else {
178-
$this->entries[$key] = $entry;
179-
return true;
180177
}
178+
179+
$this->entries[$key] = $entry;
180+
return true;
181181
}
182182

183183
/**

src/PoHeader.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,12 @@ public function setHeader(string $key, string $value): void
105105
{
106106
$this->buildStructuredHeaders();
107107
$lkey = strtolower($key);
108+
$newHeader = array('key' => $key, 'value' => $value);
108109
if (isset($this->structuredHeaders[$lkey])) {
109-
$this->structuredHeaders[$lkey]['value'] = $value;
110-
} else {
111-
$newHeader = array('key' => $key, 'value' => $value);
112-
$this->structuredHeaders[$lkey] = $newHeader;
110+
$newHeader = $this->structuredHeaders[$lkey];
111+
$newHeader['value'] = $value;
113112
}
113+
$this->structuredHeaders[$lkey] = $newHeader;
114114
$this->storeStructuredHeader();
115115
}
116116

src/PoInitAbstract.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,8 @@ public function addPgettextTags($tags): void
172172
*/
173173
public function msginitFile(string $filename): PoFile
174174
{
175-
if (!is_readable($filename)) {
176-
$source = false;
177-
} else {
175+
$source = false;
176+
if (is_readable($filename)) {
178177
$source = file_get_contents($filename);
179178
}
180179
if (false===$source) {

0 commit comments

Comments
 (0)