views: add series-detail view

Signed-off-by: andrepapoti <andrepapoti@gmail.com>
Signed-off-by: Victor Accarini <victor.accarini@profusion.mobi>

Author: andrepapoti

patchwork/models.py

@@ -1095,10 +1095,10 @@ def add_patch(self, patch, number):
         return patch
 
     def get_absolute_url(self):
-        # TODO(stephenfin): We really need a proper series view
         return reverse(
-            'patch-list', kwargs={'project_id': self.project.linkname}
-        ) + ('?series=%d' % self.id)
+            'series-detail',
+            kwargs={'project_id': self.project.linkname, 'series_id': self.id},
+        )
 
     def get_mbox_url(self):
         return reverse('series-mbox', kwargs={'series_id': self.id})

patchwork/templates/patchwork/partials/download-buttons.html

@@ -1,4 +1,5 @@
 <div class="btn-group pull-right">
+{% if submission %}
   <button type="button" class="btn btn-default btn-copy"
       data-clipboard-text="{{ submission.id }}" title="Copy to Clipboard">
     {{ submission.id }}
@@ -24,4 +25,14 @@
     series
   </a>
 {% endif %}
+{% elif series %}
+  <button type="button" class="btn btn-default btn-copy"
+      data-clipboard-text="{{ series.id }}" title="Copy to Clipboard">
+    {{ series.id }}
+  </button>
+  <a href="{% url 'series-mbox' series_id=series.id %}"
+      class="btn btn-default" role="button" title="Download series mbox">
+    series
+  </a>
+{% endif %}
 </div>

patchwork/templates/patchwork/series-detail.html

@@ -0,0 +1,54 @@
+{% extends "base.html" %}
+
+{% load humanize %}
+{% load syntax %}
+{% load person %}
+{% load patch %}
+{% load static %}
+{% load utils %}
+
+{% block title %}{{series.name}}{% endblock %}
+
+{% block body %}
+
+<div>
+{% include "patchwork/partials/download-buttons.html" %}
+  <h1>{{ series.name }}</h1>
+</div>
+
+<table class="patch-meta">
+    <tr>
+        <th>Series ID</th>
+        <td>
+            {{ series.id }}
+            <span class="btn-link btn-copy glyphicon glyphicon-copy" data-clipboard-text="{{ request.build_absolute_uri }}{{ series.get_absolute_url }}" title="Copy to Clipboard"></span>
+        </td>
+    </tr>
+    <tr>
+        <th>Date</th>
+        <td>{{ series.date }}</td>
+    </tr>
+    <tr>
+        <th>Submitter</th>
+        <td>{{ series.submitter }}</td>
+    </tr>
+    <tr>
+        <th>Total</th>
+        <td>{{ series.patches }}</td>
+    </tr>
+</table>
+<br>
+<h2>Patches</h2>
+<br>
+{% include "patchwork/partials/patch-list.html" %}
+
+<div id="cover-letter">
+    <h2>Cover Letter</h2>
+    {% if series.cover_letter.content %}
+    <pre class="content">{{ series.cover_letter.content }}</pre>
+    {% else %}
+    No cover letter available
+    {% endif %}
+</div>
+
+{% endblock %}

patchwork/templates/patchwork/series-list.html

@@ -84,7 +84,9 @@
       </td>
 {% endif %}
       <td>
+        <a href="{% url 'series-detail' project_id=project.linkname series_id=series.id %}?state=*">
           {{ series.name|default:"[no subject]"|truncatechars:100 }}
+        </a>
       </td>
       <td>
         {{ series.version|default:"-"}}

patchwork/urls.py

@@ -120,6 +120,11 @@
         name='comment-redirect',
     ),
     # series views
+    path(
+        'project/<project_id>/series/<int:series_id>/',
+        series_views.series_detail,
+        name='series-detail',
+    ),
     path(
         'series/<int:series_id>/mbox/',
         series_views.series_mbox,

patchwork/views/series.py

@@ -9,7 +9,9 @@
 from django.shortcuts import render
 
 from patchwork.models import Series
+from patchwork.models import Patch
 from patchwork.models import Project
+from patchwork.views import generic_list
 from patchwork.views.utils import series_to_mbox
 from patchwork.paginator import Paginator
 
@@ -26,6 +28,27 @@ def series_mbox(request, series_id):
     return response
 
 
+def series_detail(request, project_id, series_id):
+    series = get_object_or_404(Series, id=series_id)
+
+    patches = Patch.objects.filter(series=series)
+
+    context = generic_list(
+        request,
+        series.project,
+        'series-detail',
+        view_args={
+            'project_id': project_id,
+            'series_id': series_id,
+        },
+        patches=patches,
+    )
+
+    context.update({'series': series})
+
+    return render(request, 'patchwork/series-detail.html', context)
+
+
 def series_list(request, project_id):
     project = get_object_or_404(Project, linkname=project_id)
     sort = request.GET.get('order', 'date.desc')