Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Commit 60af521

Browse files
Extract minimum required coverage by Jacoco plugin. (#541)
1 parent cd6f526 commit 60af521

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

buildSrc/src/main/java/Config.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import java.math.BigDecimal
2+
13
object Config {
24
val kotlinVersion = "1.3.72"
35
val kotlinStdLib = "stdlib-jdk8"
@@ -72,6 +74,10 @@ object Config {
7274
}
7375

7476
object QualityPlugins {
77+
object Jacoco {
78+
val version = "0.8.5"
79+
val minimumCoverage = BigDecimal.valueOf(0.6)
80+
}
7581
val jacocoVersion = "0.8.5"
7682
val spotless = "com.diffplug.spotless"
7783
val spotlessVersion = "5.1.0"

sentry-core/build.gradle.kts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ configure<SourceSetContainer> {
4343
}
4444

4545
jacoco {
46-
toolVersion = Config.QualityPlugins.jacocoVersion
46+
toolVersion = Config.QualityPlugins.Jacoco.version
4747
}
4848

4949
tasks.jacocoTestReport {
@@ -56,8 +56,7 @@ tasks.jacocoTestReport {
5656
tasks {
5757
jacocoTestCoverageVerification {
5858
violationRules {
59-
// TODO: Raise the minimum to a sensible value.
60-
rule { limit { minimum = BigDecimal.valueOf(0.1) } }
59+
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
6160
}
6261
}
6362
check {

sentry-log4j2/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ configure<SourceSetContainer> {
4444
}
4545

4646
jacoco {
47-
toolVersion = Config.QualityPlugins.jacocoVersion
47+
toolVersion = Config.QualityPlugins.Jacoco.version
4848
}
4949

5050
tasks.jacocoTestReport {
@@ -57,7 +57,7 @@ tasks.jacocoTestReport {
5757
tasks {
5858
jacocoTestCoverageVerification {
5959
violationRules {
60-
rule { limit { minimum = BigDecimal.valueOf(0.6) } }
60+
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
6161
}
6262
}
6363
check {

sentry-logback/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ configure<SourceSetContainer> {
4343
}
4444

4545
jacoco {
46-
toolVersion = Config.QualityPlugins.jacocoVersion
46+
toolVersion = Config.QualityPlugins.Jacoco.version
4747
}
4848

4949
tasks.jacocoTestReport {
@@ -56,7 +56,7 @@ tasks.jacocoTestReport {
5656
tasks {
5757
jacocoTestCoverageVerification {
5858
violationRules {
59-
rule { limit { minimum = BigDecimal.valueOf(0.6) } }
59+
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
6060
}
6161
}
6262
check {

sentry-spring-boot-starter/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ configure<SourceSetContainer> {
6363
}
6464

6565
jacoco {
66-
toolVersion = Config.QualityPlugins.jacocoVersion
66+
toolVersion = Config.QualityPlugins.Jacoco.version
6767
}
6868

6969
tasks.jacocoTestReport {
@@ -76,7 +76,7 @@ tasks.jacocoTestReport {
7676
tasks {
7777
jacocoTestCoverageVerification {
7878
violationRules {
79-
rule { limit { minimum = BigDecimal.valueOf(0.6) } }
79+
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
8080
}
8181
}
8282
check {

0 commit comments

Comments
 (0)