Skip to content

Conversation

@noahsmartin
Copy link
Contributor

Not meant to be merged, just to start discussion about #6560

This also has the benefit of unifying the debug and non-debug codepaths to reduce the chances that a bug affects one environment but not the other

#skip-changelog

@noahsmartin noahsmartin force-pushed the removeSymbolication branch 3 times, most recently from b87555b to 38f322d Compare October 28, 2025 12:25
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.361%. Comparing base (22af3fc) to head (33fbf9f).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryCrashStackEntryMapper.m 0.000% 5 Missing ⚠️
Sources/Sentry/SentryDefaultThreadInspector.m 25.000% 3 Missing ⚠️
Sources/Sentry/SentryStacktraceBuilder.m 0.000% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (22af3fc) and HEAD (33fbf9f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (22af3fc) HEAD (33fbf9f)
3 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6562        +/-   ##
=============================================
- Coverage   85.513%   7.361%   -78.152%     
=============================================
  Files          451      415        -36     
  Lines        27328    25974      -1354     
  Branches     11913     9579      -2334     
=============================================
- Hits         23369     1912     -21457     
- Misses        3914    24051     +20137     
+ Partials        45       11        -34     
Files with missing lines Coverage Δ
Sources/Sentry/include/SentryCrashDynamicLinker.h 0.000% <ø> (-100.000%) ⬇️
Sources/SentryCrash/Recording/SentryCrashReport.c 0.127% <ø> (-54.659%) ⬇️
...ryCrash/Recording/Tools/SentryCrashDynamicLinker.c 17.610% <ø> (-70.283%) ⬇️
...ntryCrash/Recording/Tools/SentryCrashStackCursor.c 0.000% <ø> (-100.000%) ⬇️
...ntryCrash/Recording/Tools/SentryCrashStackCursor.h 0.000% <ø> (-100.000%) ⬇️
Sources/Sentry/SentryStacktraceBuilder.m 7.692% <0.000%> (-68.499%) ⬇️
Sources/Sentry/SentryDefaultThreadInspector.m 15.625% <25.000%> (-83.385%) ⬇️
Sources/Sentry/SentryCrashStackEntryMapper.m 25.000% <0.000%> (-75.000%) ⬇️

... and 426 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22af3fc...33fbf9f. Read the comment docs.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.33 ms 1259.09 ms 30.77 ms
Size 23.75 KiB 1.00 MiB 1001.63 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9264ee8 1233.15 ms 1250.02 ms 16.87 ms
07d7e83 1211.71 ms 1240.08 ms 28.37 ms
119ab1c 1226.79 ms 1254.55 ms 27.76 ms
66147d5 1234.45 ms 1268.45 ms 34.00 ms
fa9a4bb 1217.91 ms 1248.72 ms 30.81 ms
be882e4 1199.35 ms 1231.20 ms 31.86 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms
f97a070 1218.88 ms 1253.12 ms 34.24 ms
339539a 1219.58 ms 1254.63 ms 35.05 ms
26f7b17 1218.47 ms 1253.82 ms 35.35 ms

App size

Revision Plain With Sentry Diff
9264ee8 23.75 KiB 913.09 KiB 889.34 KiB
07d7e83 23.75 KiB 913.27 KiB 889.52 KiB
119ab1c 23.75 KiB 993.70 KiB 969.95 KiB
66147d5 23.74 KiB 1.01 MiB 1008.77 KiB
fa9a4bb 23.75 KiB 986.91 KiB 963.16 KiB
be882e4 23.75 KiB 946.69 KiB 922.94 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB
f97a070 23.75 KiB 858.68 KiB 834.93 KiB
339539a 23.75 KiB 968.24 KiB 944.50 KiB
26f7b17 23.75 KiB 960.93 KiB 937.19 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants