-
-
Notifications
You must be signed in to change notification settings - Fork 371
feat: Move enableFileManagerSwizzling and enableDataSwizzling to top-level options #6592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…level options - Move enableFileManagerSwizzling from experimental to top-level options (default: NO) - Move enableDataSwizzling from experimental to top-level options (default: YES) - Update all implementation files and tests to use new option paths - Update documentation and sample apps - Add CHANGELOG entries Closes #4880
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
| d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
| 1bf44b4 | 1238.14 ms | 1275.45 ms | 37.31 ms |
| 63ac649 | 1192.10 ms | 1216.78 ms | 24.68 ms |
| d637379 | 1226.43 ms | 1250.77 ms | 24.34 ms |
| e446901 | 1233.32 ms | 1252.32 ms | 19.00 ms |
| be882e4 | 1199.35 ms | 1231.20 ms | 31.86 ms |
| 570f725 | 1206.00 ms | 1238.96 ms | 32.96 ms |
| 736bcfb | 1229.86 ms | 1249.59 ms | 19.73 ms |
| aa0b738 | 1236.78 ms | 1253.08 ms | 16.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
| d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| 1bf44b4 | 23.75 KiB | 1021.20 KiB | 997.45 KiB |
| 63ac649 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| d637379 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| e446901 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| be882e4 | 23.75 KiB | 946.69 KiB | 922.94 KiB |
| 570f725 | 23.74 KiB | 913.38 KiB | 889.63 KiB |
| 736bcfb | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| aa0b738 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Description
This PR moves two swizzling options from experimental to top-level options:
enableFileManagerSwizzling- Moved from experimental options to top-level (default: NO)enableDataSwizzling- Moved from experimental options to top-level (default: YES)Changes
SentryOptions.hwith proper documentationSentryOptions.mSentryExperimentalOptions.swiftTesting
Related Issues
Closes #4880
Notes
enableFileManagerSwizzlingremains disabled by default (NO) and will be enabled in a future major releaseenableDataSwizzlingremains enabled by default (YES) to maintain backward compatibility