Skip to content

Conversation

@philprime
Copy link
Member

Description

This PR moves two swizzling options from experimental to top-level options:

  1. enableFileManagerSwizzling - Moved from experimental options to top-level (default: NO)
  2. enableDataSwizzling - Moved from experimental options to top-level (default: YES)

Changes

  • ✅ Added properties to SentryOptions.h with proper documentation
  • ✅ Initialized default values in SentryOptions.m
  • ✅ Removed properties from SentryExperimentalOptions.swift
  • ✅ Updated all implementation files to use new option paths
  • ✅ Updated all test files
  • ✅ Updated sample applications
  • ✅ Updated documentation in code comments
  • ✅ Added CHANGELOG entries

Testing

  • All existing tests pass ✅ (107 tests, 0 failures)
  • No linter errors

Related Issues

Closes #4880

Notes

  • enableFileManagerSwizzling remains disabled by default (NO) and will be enabled in a future major release
  • enableDataSwizzling remains enabled by default (YES) to maintain backward compatibility

…level options

- Move enableFileManagerSwizzling from experimental to top-level options (default: NO)
- Move enableDataSwizzling from experimental to top-level options (default: YES)
- Update all implementation files and tests to use new option paths
- Update documentation and sample apps
- Add CHANGELOG entries

Closes #4880
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9332ded

@philprime philprime marked this pull request as ready for review October 29, 2025 15:32
@codecov
Copy link

codecov bot commented Oct 29, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3883 1 3882 52
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.LaunchUITests::testCaptureErrorReturnsValidId
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:57 - Failed to get matching snapshot: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.41 ms 1254.25 ms 39.84 ms
Size 23.75 KiB 1.01 MiB 1016.11 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f97a070 1218.88 ms 1253.12 ms 34.24 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms
1bf44b4 1238.14 ms 1275.45 ms 37.31 ms
63ac649 1192.10 ms 1216.78 ms 24.68 ms
d637379 1226.43 ms 1250.77 ms 24.34 ms
e446901 1233.32 ms 1252.32 ms 19.00 ms
be882e4 1199.35 ms 1231.20 ms 31.86 ms
570f725 1206.00 ms 1238.96 ms 32.96 ms
736bcfb 1229.86 ms 1249.59 ms 19.73 ms
aa0b738 1236.78 ms 1253.08 ms 16.31 ms

App size

Revision Plain With Sentry Diff
f97a070 23.75 KiB 858.68 KiB 834.93 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB
1bf44b4 23.75 KiB 1021.20 KiB 997.45 KiB
63ac649 23.75 KiB 855.38 KiB 831.63 KiB
d637379 23.75 KiB 855.38 KiB 831.63 KiB
e446901 23.75 KiB 933.33 KiB 909.58 KiB
be882e4 23.75 KiB 946.69 KiB 922.94 KiB
570f725 23.74 KiB 913.38 KiB 889.63 KiB
736bcfb 23.74 KiB 891.02 KiB 867.28 KiB
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB

Previous results on branch: philprime/enable-file-manager-swizzling

Startup times

Revision Plain With Sentry Diff
a3da96f 1223.91 ms 1262.19 ms 38.27 ms

App size

Revision Plain With Sentry Diff
a3da96f 23.75 KiB 1.01 MiB 1016.02 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@philprime philprime enabled auto-merge (squash) October 30, 2025 10:42
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNSDataSwizzling.m
  • Sources/Sentry/SentryNSFileManagerSwizzling.m

@philprime philprime merged commit 36c0d1a into main Oct 30, 2025
187 of 192 checks passed
@philprime philprime deleted the philprime/enable-file-manager-swizzling branch October 30, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make enableFileManagerSwizzling GA

3 participants