Allow any order for OnAppearing vs. receiving system breadcrumbs

Author: jpnurmi

integration-test/net9-maui/App.xaml.cs

@@ -7,49 +7,96 @@ namespace Sentry.Maui.Device.IntegrationTestApp;
 
 public partial class App : Application
 {
-    private static readonly ConcurrentDictionary<string, Breadcrumb> _breadcrumbs = new();
+    private static readonly ConcurrentDictionary<string, Dictionary<string, string>> systemBreadcrumbs = new();
+    private static string? testArg;
 
     public App()
     {
         InitializeComponent();
     }
 
-    public static string? TestArg => System.Environment.GetEnvironmentVariable("SENTRY_TEST_ARG");
-
     public static bool HasTestArg(string arg)
     {
-        return string.Equals(TestArg, arg, StringComparison.OrdinalIgnoreCase);
+        return string.Equals(testArg, arg, StringComparison.OrdinalIgnoreCase);
     }
 
-    public static void RecordBreadcrumb(Breadcrumb breadcrumb)
+    public static void ReceiveSystemBreadcrumb(Breadcrumb breadcrumb)
     {
-        if (breadcrumb.Data?.TryGetValue("action", out var action) != true)
+        if (breadcrumb.Type != "system" ||
+            breadcrumb.Data?.TryGetValue("action", out var action) != true ||
+            string.IsNullOrEmpty(action))
         {
             return;
         }
 
-        _breadcrumbs[action] = new Breadcrumb(
-            breadcrumb.Message,
-            breadcrumb.Type,
-            new Dictionary<string, string>
-            {
-                ["action"] = action,
-                ["thread_id"] = Thread.CurrentThread.ManagedThreadId.ToString()
-            },
-            breadcrumb.Category,
-            breadcrumb.Level);
+        systemBreadcrumbs[action] = new Dictionary<string, string>()
+        {
+            ["action"] = action,
+            ["category"] = breadcrumb.Category ?? string.Empty,
+            ["thread_id"] = Thread.CurrentThread.ManagedThreadId.ToString(),
+            ["type"] = breadcrumb.Type ?? string.Empty,
+        };
+
+        if (HasTestArg(action))
+        {
+            // received after OnAppearing
+            CaptureSystemBreadcrumb(action, systemBreadcrumbs[action]!);
+            Kill();
+        }
     }
 
-    public static bool TryGetBreadcrumb(string action, out Breadcrumb? breadcrumb)
+    public static void CaptureSystemBreadcrumb(string action, Dictionary<string, string> data)
     {
-        return _breadcrumbs.TryGetValue(action, out breadcrumb);
+        SentrySdk.CaptureMessage(action, scope =>
+        {
+            foreach (var kvp in data)
+            {
+                scope.SetExtra(kvp.Key, kvp.Value);
+            }
+        });
     }
 
     protected override Window CreateWindow(IActivationState? activationState)
     {
         return new Window(new AppShell());
     }
 
+    public static void OnAppearing()
+    {
+        testArg = System.Environment.GetEnvironmentVariable("SENTRY_TEST_ARG");
+
+#pragma warning disable CS0618
+        if (Enum.TryParse<CrashType>(testArg, ignoreCase: true, out var crashType))
+        {
+            SentrySdk.CauseCrash(crashType);
+        }
+#pragma warning restore CS0618
+
+        if (HasTestArg("NullReferenceException"))
+        {
+            try
+            {
+                object? obj = null;
+                _ = obj!.ToString();
+            }
+            catch (NullReferenceException ex)
+            {
+                SentrySdk.CaptureException(ex);
+            }
+            Kill();
+        }
+        else if (!string.IsNullOrEmpty(testArg) && systemBreadcrumbs.TryGetValue(testArg, out var breadcrumb))
+        {
+            // received before OnAppearing
+            CaptureSystemBreadcrumb(testArg, breadcrumb);
+            Kill();
+        }
+        else if (HasTestArg("None"))
+        {
+            Kill();
+        }
+    }
+
     public static void Kill()
     {
         SentrySdk.Close();

integration-test/net9-maui/MainPage.xaml.cs

@@ -11,38 +11,6 @@ protected override void OnAppearing()
     {
         base.OnAppearing();
 
-#pragma warning disable CS0618
-        if (Enum.TryParse<CrashType>(App.TestArg, ignoreCase: true, out var crashType))
-        {
-            SentrySdk.CauseCrash(crashType);
-        }
-#pragma warning restore CS0618
-
-        if (App.HasTestArg("NullReferenceException"))
-        {
-            try
-            {
-                object? obj = null;
-                _ = obj!.ToString();
-            }
-            catch (NullReferenceException ex)
-            {
-                SentrySdk.CaptureException(ex);
-            }
-        }
-        else if (App.TryGetBreadcrumb(App.TestArg, out var breadcrumb) && breadcrumb.Data != null)
-        {
-            SentrySdk.CaptureMessage(App.TestArg, scope =>
-            {
-                scope.SetExtra("category", breadcrumb.Category);
-                foreach (var kvp in breadcrumb.Data)
-                {
-                    scope.SetExtra(kvp.Key, kvp.Value);
-                }
-                scope.SetExtra("type", breadcrumb.Type);
-            });
-        }
-
-        App.Kill();
+        App.OnAppearing();
     }
 }

integration-test/net9-maui/MauiProgram.cs

@@ -23,7 +23,7 @@ public static MauiApp CreateMauiApp()
 
                 options.SetBeforeBreadcrumb((breadcrumb, hint) =>
                 {
-                    App.RecordBreadcrumb(breadcrumb);
+                    App.ReceiveSystemBreadcrumb(breadcrumb);
                     return breadcrumb;
                 });
             })